Discord rich presence support for various client mods#666
Open
Discord rich presence support for various client mods#666
Conversation
JakeMT04
changed the title
it can come back when I can be bothered to do the packet impl
mworzala
reviewed
Apr 27, 2025
modules/common/src/main/java/net/hollowcube/common/util/WordUtil.java
Outdated
Show resolved
Hide resolved
modules/compat/src/main/java/net/hollowcube/compat/api/discord/DiscordRichPresenceProvider.java
Outdated
Show resolved
Hide resolved
modules/hub/src/main/java/net/hollowcube/mapmaker/hub/HubMapWorld.java
Outdated
Show resolved
Hide resolved
ThatGravyBoat
requested changes
Apr 27, 2025
| } | ||
|
|
||
| if (event.getIdentifier().equalsIgnoreCase("minecraft:register")) { | ||
| if (event.getMessageString().contains("lunar:apollo") || event.getMessageString().contains("apollo:json")) { |
Member
There was a problem hiding this comment.
this should probably be turned into its own thing in the CompatProvider that will call a method on all providers after registers happen and then they can use PacketQueue.get(player).channels().contains()
modules/compat/src/main/java/net/hollowcube/compat/lunar/packets/ClientboundLunarPacket.java
Outdated
Show resolved
Hide resolved
modules/hub/src/main/java/net/hollowcube/mapmaker/hub/HubMapWorld.java
Outdated
Show resolved
Hide resolved
# Conflicts: # bin/development/build.gradle.kts # bin/development/src/main/java/net/hollowcube/mapmaker/dev/DevServerRunner.java # gradle/libs.versions.toml # modules/hub/build.gradle.kts
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #609
Currently implements Lunar Client, Feather Client,
and LabyModnvm labymod sucks