Skip to content

Save item cooldown states#875

Open
Exterminate5573 wants to merge 3 commits intohollow-cube:mainfrom
Exterminate5573:fix/item-cooldowns
Open

Save item cooldown states#875
Exterminate5573 wants to merge 3 commits intohollow-cube:mainfrom
Exterminate5573:fix/item-cooldowns

Conversation

@Exterminate5573
Copy link

@Exterminate5573 Exterminate5573 commented Mar 24, 2026

Closes #730

@CLAassistant
Copy link

CLAassistant commented Mar 24, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ThatGravyBoat ThatGravyBoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth renaming cooldown groups to just cooldowns and set item cooldowns to just set cooldowns to keep it consistent

@mworzala
Copy link
Contributor

Currently gives an NPE when verifying an empty map

Caused by: java.lang.NullPointerException: Cannot invoke "net.hollowcube.mapmaker.runtime.PlayState.cooldownGroups()" because the return value of "net.hollowcube.mapmaker.runtime.PlayState.lastState()" is null
	at net.hollowcube.mapmaker.runtime.parkour.ParkourState$AnyPlaying.resetPlayer(ParkourState.java:152)
	at net.hollowcube.mapmaker.runtime.parkour.ParkourState$Playing2.resetPlayer(ParkourState.java:230)
	at net.hollowcube.mapmaker.runtime.parkour.ParkourState$Playing2.resetPlayer(ParkourState.java:197)
	at net.hollowcube.mapmaker.map.AbstractMapWorld.safePointTick(AbstractMapWorld.java:321)
	at net.hollowcube.mapmaker.map.AbstractMultiMapServer.safePointTick(AbstractMultiMapServer.java:399)
	... 12 common frames omitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cooldowns do not reset or reset incorrectly

4 participants