Prepare for Holochain 0.3 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThetaSinner
commented
Nov 8, 2023
src/api/client.ts
Outdated
| }).join(', ') | ||
| } | ||
|
|
||
| console.log("sending message", request, toHexString(encode(request) as unknown as number[])) |
There was a problem hiding this comment.
This is super useful for debugging, do not intend to it to be merged to main!
|
This is enough to get a |
|
Yeah groovy! No, I hadn't noticed that the ser/de had changed on the Holochain side. I'm grateful for you help. The tests weren't completely broken, only 2 of them weren't passing. The fix was the same as you did for serializing requests, but for deserializing responses. Should be good to go now. |
|
Oh good! I ran them locally and they dumped out a lot of complaints so I assumed I'd caused some breakage. Great that it was closer than I thought :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this issue #211 and this conversation https://discord.com/channels/727959104777224303/728647693244694648/1171849740850319370