Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make builder image arch selectible #231

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Feb 22, 2025

With this we can use the home-assistant/builder action also on the new arm runners by passing image: aarch64 when running on ubuntu-24.04-arm - example mib1185/ha-addon-syslog#19
Maybe we could also auto-detect the arch of the runner, but I didn't find a reliable way to determine the runners architecture.

Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mib1185
Copy link
Contributor Author

mib1185 commented Feb 25, 2025

is it realistic to get this merged and a new release done in time? if yes, I would like to adjust the ha-core CI before beta-cut, so it can use the new arm-runners for building the arm wheels

@agners
Copy link
Member

agners commented Feb 25, 2025

is it realistic to get this merged and a new release done in time? if yes, I would like to adjust the ha-core CI before beta-cut, so it can use the new arm-runners for building the arm wheels

Yeah I was intending to do a release, also to get the work around for the QEMU build issues deployed (#229).

@agners agners merged commit f2198ad into home-assistant:master Feb 25, 2025
9 checks passed
@agners
Copy link
Member

agners commented Feb 25, 2025

New builder 2025.02.0 out!

@mib1185 mib1185 deleted the patch-1 branch February 25, 2025 14:16
@mib1185
Copy link
Contributor Author

mib1185 commented Feb 25, 2025

if yes, I would like to adjust the ha-core CI before beta-cut

mehhh ... the ci to build the wheels uses the home-assistant/wheels action, which relies on the multiarch/qemu-user-static docker, which only supports x86_64 host-architecture at the moment 🙁 so the wheels CI needs to be migrated first to (Frenck did also give it already a try home-assistant/core#137694)

@agners
Copy link
Member

agners commented Feb 26, 2025

mehhh ... the ci to build the wheels uses the home-assistant/wheels action, which relies on the multiarch/qemu-user-static docker, which only supports x86_64 host-architecture at the moment 🙁 so the wheels CI needs to be migrated first to (Frenck did also give it already a try home-assistant/core#137694)

Hm, I see. This looks like rather trivial to fix, made an attempt here: home-assistant/wheels#837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants