Add actronairneo climate integration #134740
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @kclif9,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
779c15d9f917fd77a8b23bccf66d699ca964fa50- This commit has something that looks like an email address ([email protected]). Maybe try linking that to GitHub?.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <[email protected]>"[email protected]" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
home-assistant
bot
added
cla-error
has-tests
integration: actronair_neo
new-integration
labels
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I believe I've implemented all the bronze standard rules. Can you please advise which need to be fixed? |
|
Thanks @joostlek for your review! I really appreciate the help. Hopefully that's all of the comments sorted! |
| for system in self.ac_systems: | ||
| serial_number = system["serial"] | ||
| await self.async_set_unique_id(serial_number) | ||
| self._abort_if_unique_id_configured() | ||
| return self.async_create_entry( | ||
| title=system["description"], | ||
| data={ | ||
| CONF_API_TOKEN: self.api.pairing_token, | ||
| CONF_DEVICE_ID: serial_number, | ||
| }, |
There was a problem hiding this comment.
This retrieves all of the systems retrieved by the API rather than before your previous review where it was just the user selected system serial_number on the config_entry.
There was a problem hiding this comment.
Right, but we return in the for loop, so this will only create 1 entry. Can't we fetch all the entries during setup instead?
Like, instead of having 1 entry = 1 device, have 1 entry = 1 account = n devices
Co-authored-by: Joost Lekkerkerker <[email protected]>
Co-authored-by: Joost Lekkerkerker <[email protected]>
| for system in self.ac_systems: | ||
| serial_number = system["serial"] | ||
| await self.async_set_unique_id(serial_number) | ||
| self._abort_if_unique_id_configured() | ||
| return self.async_create_entry( | ||
| title=system["description"], | ||
| data={ | ||
| CONF_API_TOKEN: self.api.pairing_token, | ||
| CONF_DEVICE_ID: serial_number, | ||
| }, |
There was a problem hiding this comment.
Right, but we return in the for loop, so this will only create 1 entry. Can't we fetch all the entries during setup instead?
Like, instead of having 1 entry = 1 device, have 1 entry = 1 account = n devices
| self._attr_translation_placeholders = {"serial_number": self._serial_number} | ||
| self._attr_name = f"AC Unit {self._serial_number}" |
There was a problem hiding this comment.
My second question hasn't been answered, how does the device naming works?
Proposed change
Contribute a new integration to Home Assistant - Actron Air Neo. This PR pertains to the Climate platform.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: