Add support for standard horizontal vane modes #136654
Open
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
integration: melcloud
new-feature
small-pr
|
Hey there @erwindouna, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
antlarr
force-pushed
the
melcloud_add_horizontal_vane_support
branch
from
783d64c to
9ef493f
Compare
joostlek
requested changes
Jan 28, 2025
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
antlarr
force-pushed
the
melcloud_add_horizontal_vane_support
branch
from
8690ea0 to
5bc07e1
Compare
antlarr
force-pushed
the
melcloud_add_horizontal_vane_support
branch
from
5bc07e1 to
577fa80
Compare
Since homeassistant recently added standard way to implement horizontal vane support in climate entities, this commit adds support for those in melcloud devices. I own a device that is managed with the melcloud integration where I tested this. In the future it would be interesting to remove the custom vane support in the melcloud integration and only use the standard services/methods but this would break existing automations so IMO it should be deprecated and cleaned up in a future version. In the meantime, it doesn't hurt to have both ways to access the same states.
Fix parameter name to use swing_horizontal_mode in async_set_swing_horizontal_mode
Reimplement async_update in AtaDeviceClimate (from MelCloudClimate) so that when the device information is obtained from the cloud, we check if the device has horizontal vanes to mark SWING_HORIZONTAL_MODE as a supported feature. Note that we can't just check for self._device.vane_horizontal in __init__ since vane_horizontal is only set (or not) after the device data is fetched from the cloud.
antlarr
force-pushed
the
melcloud_add_horizontal_vane_support
branch
from
577fa80 to
174315a
Compare
|
@joostlek, is there anything missing here that I need to fix? afaik, it should be fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This commit allows users that have HVACs devices managed with melcloud to use the standard climate card to set the horizontal vane mode.
This just implements the standard methods added recently for horizontal vane support (as explained in https://developers.home-assistant.io/blog/2024/12/03/climate-horizontal-swing/ which was very helpful in knowing of this new support) in melcloud.
Type of change
Additional information
I tested this in my own melcloud devices.
In the future it would be interesting to remove the custom vane support in the melcloud integration and only use the standard services/methods but this would break existing automations so IMO it should be deprecated and cleaned up in a separate PR to be merged in a future version. In the meantime, it doesn't hurt to have both ways to access the same states. If someone points me to some documentation on how to deprecate services, I'll be glad to submit a PR too for that.
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: