Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redgtech integration #136947

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

Conversation

Jonhsady
Copy link

@Jonhsady Jonhsady commented Jan 30, 2025

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@home-assistant home-assistant bot marked this pull request as draft January 30, 2025 19:22
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Jonhsady Jonhsady marked this pull request as ready for review January 30, 2025 19:40
Copy link
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for contributing. However, there's a couple of things wrong with this PR

  • it's missing a meaningful description
  • it's adding more than one platform, which the bot already told you
  • it doesn't use a library on PyPi for abstracting the actual API communication

please check the Development Checklist

Thanks 👍

@home-assistant home-assistant bot marked this pull request as draft January 30, 2025 20:12
@Jonhsady Jonhsady marked this pull request as ready for review February 2, 2025 21:13
@home-assistant home-assistant bot requested a review from zweckj February 2, 2025 21:13
Copy link
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to be rude, but please, read the development guidelines.

  • you still have more than one platform (light & switch)
  • your library code is not publicly avaiable on a repository (not PyPi), OSI license, automated & tagged releases
  • you're quality scale is way off (e.g. you DO have stateful entities)
  • only by glancing at your code I can tell you didn't really read the quality scale criteria (e.g. runtime-data)

@home-assistant home-assistant bot marked this pull request as draft February 3, 2025 19:12
@Jonhsady Jonhsady marked this pull request as ready for review February 4, 2025 16:31
@home-assistant home-assistant bot requested a review from zweckj February 4, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants