-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add redgtech integration #136947
base: dev
Are you sure you want to change the base?
add redgtech integration #136947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for contributing. However, there's a couple of things wrong with this PR
- it's missing a meaningful description
- it's adding more than one platform, which the bot already told you
- it doesn't use a library on PyPi for abstracting the actual API communication
please check the Development Checklist
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to be rude, but please, read the development guidelines.
- you still have more than one platform (light & switch)
- your library code is not publicly avaiable on a repository (not PyPi), OSI license, automated & tagged releases
- you're quality scale is way off (e.g. you DO have stateful entities)
- only by glancing at your code I can tell you didn't really read the quality scale criteria (e.g.
runtime-data
)
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: