Skip to content

Commit

Permalink
Change "Require confirmation" default value to false (#3443)
Browse files Browse the repository at this point in the history
<!-- Thank you for submitting a Pull Request and helping to improve Home
Assistant. Please complete the following sections to help the processing
and review of your changes. Please do not delete anything from this
template. -->

## Summary
<!-- Provide a brief summary of the changes you have made and most
importantly what they aim to achieve -->

## Screenshots
<!-- If this is a user-facing change not in the frontend, please include
screenshots in light and dark mode. -->

## Link to pull request in Documentation repository
<!-- Pull requests that add, change or remove functionality must have a
corresponding pull request in the Companion App Documentation repository
(https://github.com/home-assistant/companion.home-assistant). Please add
the number of this pull request after the "#" -->
Documentation: home-assistant/companion.home-assistant#

## Any other notes
<!-- If there is any other information of note, like if this Pull
Request is part of a bigger change, please include it here. -->
  • Loading branch information
bgoncal authored Feb 19, 2025
1 parent 9a69542 commit e566ace
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ struct MagicItemCustomizationView: View {
}
Section {
Toggle(L10n.MagicItem.RequireConfirmation.title, isOn: .init(get: {
viewModel.item.customization?.requiresConfirmation ?? true
viewModel.item.customization?.requiresConfirmation ?? false
}, set: { newValue in
viewModel.item.customization?.requiresConfirmation = newValue
}))
Expand Down
2 changes: 1 addition & 1 deletion Sources/Shared/MagicItem/MagicItem.swift
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public struct MagicItem: Codable, Equatable, Hashable {
iconColor: String? = nil,
textColor: String? = nil,
backgroundColor: String? = nil,
requiresConfirmation: Bool = true,
requiresConfirmation: Bool = false,
icon: String? = nil
) {
self.iconColor = iconColor
Expand Down

0 comments on commit e566ace

Please sign in to comment.