Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests traceability, add test for Systemd dependency cycles #3917

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Improve tests traceability, add test for Systemd dependency cycles #3917

merged 1 commit into from
Mar 6, 2025
+13 −11

Conversation

sairon
Copy link
Member

@sairon sairon commented Mar 6, 2025 •
edited by coderabbitai bot
Loading

  • Add test checking journal logs for dependency cycles
  • Run some test cases to get their output also when full init fails
  • Remove high timeouts from the times when GHA couldn't use KVM
  • Enable logging durations for future optimizations

Summary by CodeRabbit

  • Tests
    • Updated the test runner to provide more detailed duration metrics.
    • Adjusted several test timeouts for quicker feedback.
    • Removed dependencies between tests to allow for independent execution.
    • Added a new test to check for proper management of system dependency cycles.

@sairon
Improve tests traceability, add test for Systemd dependency cycles
7ff1a9c 
* Add test checking journal logs for dependency cycles
* Run some test cases to get their output also when full init fails
* Remove high timeouts from the times when GHA couldn't use KVM
* Enable logging durations for future optimizations
@sairon sairon added the build Build and CI related issues label Mar 6, 2025
@sairon sairon requested a review from agners March 6, 2025 14:56
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2025

📝 Walkthrough

Walkthrough

The changes update the test execution process. The GitHub Actions workflow command now includes additional parameters that report test durations. In the smoke tests, the timeout for initialization is lowered and dependency annotations have been removed from several test functions while adding a new test to detect systemd dependency cycles. Similar timeout reductions have been applied in the offline and supervisor test suites, ensuring tests complete faster.

Changes

File(s) Change Summary
.github/workflows/test.yaml Updated the "Run tests" step command to append --durations=0 and --durations-min=5.0 parameters.
tests/smoke_test/test_basic.py Reduced the test_init timeout from 600 to 120 seconds; removed dependency annotations from tests (test_rauc_status, test_dmesg, test_systemctl_status, test_kernel_not_tainted); added test_systemctl_no_cycles to check for systemd dependency cycles.
tests/smoke_test/test_offline.py Reduced the timeout for test_ha_runs_offline from 300 to 120 seconds.
tests/supervisor_test/test_supervisor.py Reduced timeout values for supervisor tests: test_start_supervisor (600→120 seconds), test_update_supervisor (300→120 seconds), and test_restart_supervisor (450→120 seconds).
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 36d9057 and 7ff1a9c.

📒 Files selected for processing (4)
  • .github/workflows/test.yaml (1 hunks)
  • tests/smoke_test/test_basic.py (2 hunks)
  • tests/smoke_test/test_offline.py (1 hunks)
  • tests/supervisor_test/test_supervisor.py (3 hunks)
🔇 Additional comments (11)
tests/smoke_test/test_offline.py (1)

30-30: Timeout reduction for test_ha_runs_offline is appropriate.

Reducing the timeout from 300s to 120s aligns with the PR objective of removing high timeouts. The test should complete faster with KVM acceleration in GitHub Actions, making this a reasonable adjustment.

.github/workflows/test.yaml (1)

77-77: Excellent addition of test duration logging.

Adding --durations=0 --durations-min=5.0 parameters will report durations for all tests with a minimum threshold of 5.0 seconds. This directly implements the PR objective to enable logging of operation durations, which will be valuable for future optimizations.

tests/supervisor_test/test_supervisor.py (3)

19-19: Appropriate timeout reduction for test_start_supervisor.

Reducing the timeout from 600s to 120s aligns with the PR objective of removing unnecessarily high timeouts. With KVM acceleration, this should be sufficient.

58-58: Appropriate timeout reduction for test_update_supervisor.

Reducing the timeout from 300s to 120s aligns with the PR objective of removing unnecessarily high timeouts. With KVM acceleration, this should be sufficient.

156-156: Appropriate timeout reduction for test_restart_supervisor.

Reducing the timeout from 450s to 120s aligns with the PR objective of removing unnecessarily high timeouts. With KVM acceleration, this should be sufficient.

tests/smoke_test/test_basic.py (6)

11-11: Appropriate timeout reduction for test_init.

Reducing the timeout from 600s to 120s aligns with the PR objective of removing unnecessarily high timeouts. With KVM acceleration, this should be sufficient.

38-55: Good removal of dependency on test_init.

Removing the dependency on test_init for test_rauc_status allows this test to run independently, even if initialization fails. This directly implements the PR objective to capture test output even when full initialization fails.

57-60: Good removal of dependency on test_init.

Removing the dependency on test_init for test_dmesg allows capturing valuable diagnostic information from kernel logs even when initialization fails. This directly implements the PR objective.

68-71: Good removal of dependency on test_init.

Removing the dependency on test_init for test_systemctl_status allows capturing service status information even when initialization fails. This directly implements the PR objective.

78-82: Excellent new test for systemd dependency cycles.

This new test implements the PR objective of introducing a test that checks journal logs specifically for systemd dependency cycles. It uses a simple grep approach since systemd-analyze isn't available.

109-114: Good removal of dependency on test_init.

Removing the dependency on test_init for test_kernel_not_tainted allows checking kernel integrity even when initialization fails. This directly implements the PR objective.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sairon sairon merged commit 4a1d2b7 into dev Mar 6, 2025
3 checks passed
@sairon sairon deleted the improve-tests-traceability branch March 6, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agners agners agners approved these changes

Assignees
No one assigned
Labels
build Build and CI related issues cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sairon @agners