Issue 07 create game struct #10
Conversation
| type Game struct { | ||
| players []Player | ||
| enemies []Enemy | ||
| goals []Goal |
There was a problem hiding this comment.
Goals? not Crystals? Am I mistaken that the objective is to get all crystals?
There was a problem hiding this comment.
yeah, i suppose I was just trying to make the name generic. like, when we skin it, enemies might become "ghosts" or "monsters", in the same way that goals are crystals
| @@ -0,0 +1,10 @@ | |||
| package state | |||
|
|
|||
| type Game struct { | |||
There was a problem hiding this comment.
Should the game also have some kind of boundaries for where the entities can be located? I figure that we should just display a static board size, so knowing what that size is will be useful.
There was a problem hiding this comment.
yep, will plan to add boundaries in the next PR
| if (goty != 0.0) { | ||
| t.Errorf("Initialized enemy did not have default y velocity 0.0") | ||
| } | ||
| } |
There was a problem hiding this comment.
Default geometry test? Also for your players tests.
On a related note too, should the default radius be 1 instead of the built in value of 0? It seems weird to have an entity with no size.
There was a problem hiding this comment.
Default geo test is a good idea, i will add
agreed that the default radius should be 1, but Go does not have a way to set a default for a struct member that isn't the same as that native type's default. There's no constructor or anything either.
To get non-0 defaults we will need to establish a pattern of our own "constructor" methods and make a habit of calling them. From what I've read, Init() is a common name for struct initializers. I think that's out of the scope of this PR, but would go well with the next one containing default boundaries
| t.Errorf("X not retrieved correctly got %v, wanted %v ", loc.x, 1.0) | ||
| } | ||
| if (loc.y != -1.5) { | ||
| t.Errorf("Y not retrieved correctly got %v, wanted %v ", loc.x, 1.0) |
There was a problem hiding this comment.
loc here is incorrect, should be -1.5
| t.Errorf("X not retrieved correctly got %v, wanted %v ", vel.x, 1.0) | ||
| } | ||
| if (vel.y != -1.5) { | ||
| t.Errorf("Y not retrieved correctly got %v, wanted %v ", vel.x, 1.0) |
| package state | ||
|
|
||
| type Player struct { | ||
| location Location |
There was a problem hiding this comment.
Do we also need something here to represent the player's controllable actions?
There was a problem hiding this comment.
yes, will add in a another PR
No description provided.