-
-
Notifications
You must be signed in to change notification settings - Fork 837
perf: make functions common for reduce code size #4111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: EdamAmex <[email protected]>
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4111 +/- ##
==========================================
+ Coverage 91.31% 91.66% +0.35%
==========================================
Files 168 169 +1
Lines 10790 10692 -98
Branches 3067 3055 -12
==========================================
- Hits 9853 9801 -52
+ Misses 936 890 -46
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
Bundle size check
Compiler Diagnostics (tsc)
Reported by octocov |
Bundle size check
Compiler Diagnostics (typescript-go)
Reported by octocov |
|
Hey @EdamAme-x Do you think merging this PR is worth it? If so, please review this. |
|
Hello @usualoma ! What do you think of this optimization? |
|
Hi @yusukebe. If you ask me if it's really necessary, I'd say it's a gray area, but I don't think it will reduce maintainability, so it's fine. |
|
Thanks! I also think this is a "gray area". I'll decide whether to merge later. |
This PR reduces the bundle code size with common functions that can't be minified with the bundler.
Created the following functions:
createEmptyRecordcreateResponseAnd applied to the core files. I think we don't have to optimize unrelated to the core like under
src/middlewarenow.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code