Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/auth flow #341

Merged
merged 12 commits into from
Feb 25, 2025
Merged

Fix/auth flow #341

merged 12 commits into from
Feb 25, 2025

Conversation

jeafreezy
Copy link
Collaborator

@jeafreezy jeafreezy commented Feb 24, 2025

Fixes #338

Description

This PR enhanced the Authentication flow by creating a new callback route (/authenticate) to handle OSM redirection. See attached image. Also, we enhanced the flow by showing a modal to let the user know authentication is via OpenStreetMap rather than redirecting them to it directly, as we did before.

image

Checklist

  • Tests were added

Demo

Screen.Recording.2025-02-24.at.19.07.08.mov

@kshitijrajsharma , we won't be able to test this on my Vercel deployment because OSM redirects to the dev deployment, if we can deploy this to the dev , we can be able to test.

@kshitijrajsharma kshitijrajsharma merged commit 3bfe980 into hotosm:develop Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Authentication Flow Bug
2 participants