Change docs, storybook for disabled button #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
Ah perfect, thanks Emi! LGTM! 👍 |
|
Nice, thanks! I think you might have autoformatting turned on in your IDE by the way - watch out it doesn't conflict with the configured pre-commit hooks. To keep consistent, install the pre-commit hooks: pip install pre-commit
pre-commit install |
|
Oh yes @spwoodcock I might be the case! , for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
disabledButton the correct way to use the property is:<hot-button disabled>Instead of:
<hot-button disabled="true">Because anything inside the argument's value will result in a "True" value (because it's a string).
I modified the README.md file with this change and also added the property to the component's story, because it wasn't working when using the "disabled" switch.