Skip dispatching messages if Turbo is not loaded #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codergeek121
reviewed
Feb 6, 2025
|
@codergeek121 I adopted your suggestions and it should be good now. |
| @@ -1569,6 +1569,10 @@ var HotwireSpark = (function () { | |||
| return new ReplaceHtmlReloader().reload(); | |||
| } | |||
| async reload() { | |||
| if (!window.Turbo) { | |||
| console.log(`[hotwire-spark] Tried to replace the page with Turbo, but Turbo is not available on window.Turbo`); | |||
There was a problem hiding this comment.
A small nitpick to align with the existing logger:
Suggested change
| console.log(`[hotwire-spark] Tried to replace the page with Turbo, but Turbo is not available on window.Turbo`); | |
| console.log(`[hotwire_spark] Tried to replace the page with Turbo, but Turbo is not available on window.Turbo`); |
I'd probably extract to logger.js and extract a const TAG = "[hotwire_spark]".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark raises errors on pages where Turbo is not loaded. We now check to see if Turbo is loaded before trying to action on the messages.
My Use Case
I have a Rails app where I am using Turbo on the majority of pages, but specific pages are using React. Spark raises errors in my JS console when I am on those React pages.
Considerations
I wasn't sure if this should be a
console.logto warn people or use the internal log function. I went with the internal log so that it wouldn't be noisy for people who know what they are doing. However I could see this as being confusing for first time users who maybe don't have Turbo loaded and don't understand why it isn't working.