Skip to content

Feat/v4 Twilio iOS v5 #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Feat/v4 Twilio iOS v5 #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
96f1f1c
Initial iOS 5.x SDK integration
lonnylot Dec 28, 2019
f268668
Corrected how cancelled call invites are found
lonnylot Dec 28, 2019
db3447e
Minor refactoring
lonnylot Jan 3, 2020
f41bb34
Updated README
lonnylot Jan 3, 2020
3132dc2
Fixed setMuted and setSpeakerPhone
lonnylot Jan 6, 2020
401cfa1
Implemented 'deviceDidReceiveIncoming' for iOS; added missing callRej…
lonnylot Jan 6, 2020
059f519
Updated param keys in getActiveCall response
lonnylot Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This is a React Native wrapper for Twilio Programmable Voice SDK that lets you m
# Twilio Programmable Voice SDK

- Android 2.1.0 (bundled within this library)
- iOS 2.1.0 (specified by the app's own podfile)
- iOS 5.1.1 (specified by the app's own podfile; min. version 5.x)

## Breaking changes in v4.0.0

Expand Down Expand Up @@ -63,11 +63,11 @@ Edit your `Podfile` to include TwilioVoice framework
source 'https://github.com/cocoapods/specs'

# min version for TwilioVoice to work
platform :ios, '8.1'
platform :ios, '10.0'

target <YOUR_TARGET> do
...
pod 'TwilioVoice', '~> 2.1.0'
pod 'TwilioVoice', '~> 5.1.1'
...
end

Expand All @@ -82,11 +82,11 @@ Edit your `Podfile` to include TwilioVoice and RNTwilioVoice frameworks
source 'https://github.com/cocoapods/specs'

# min version for TwilioVoice to work
platform :ios, '8.1'
platform :ios, '10.0'

target <YOUR_TARGET> do
...
pod 'TwilioVoice', '~> 2.1.0'
pod 'TwilioVoice', '~> 5.1.1'
pod 'RNTwilioVoice', path: '../node_modules/react-native-twilio-programmable-voice'
...
end
Expand Down Expand Up @@ -291,10 +291,6 @@ TwilioVoice.addEventListener('connectionDidDisconnect', function(data: mixed) {
// }
})

// iOS Only
TwilioVoice.addEventListener('callRejected', function(value: 'callRejected') {})

// Android Only
TwilioVoice.addEventListener('deviceDidReceiveIncoming', function(data) {
// {
// call_sid: string, // Twilio call sid
Expand All @@ -303,6 +299,10 @@ TwilioVoice.addEventListener('deviceDidReceiveIncoming', function(data) {
// call_to: string, // "client:bob"
// }
})

// iOS Only
TwilioVoice.addEventListener('callRejected', function(value: 'callRejected') {})

// Android Only
TwilioVoice.addEventListener('proximity', function(data) {
// {
Expand Down
12 changes: 6 additions & 6 deletions RNTwilioVoice.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ Pod::Spec.new do |s|
s.authors = spec['author']['name']
s.homepage = spec['homepage']
s.license = spec['license']
s.platform = :ios, "8.1"
s.platform = :ios, "10.0"

s.source_files = [ "ios/RNTwilioVoice/*.h", "ios/RNTwilioVoice/*.m"]
s.source_files = [ "ios/RNTwilioVoice/RNTwilioVoice.h", "ios/RNTwilioVoice/RNTwilioVoice.m"]
s.source = {:path => "./RNTwilioVoice"}

s.dependency 'React'
s.xcconfig = { 'FRAMEWORK_SEARCH_PATHS' => '${PODS_ROOT}/TwilioVoice' }
s.frameworks = 'TwilioVoice'
end
s.dependency "React"
s.xcconfig = { "FRAMEWORK_SEARCH_PATHS" => "\"${PODS_ROOT}/TwilioVoice/Build/iOS\"" }
s.frameworks = "TwilioVoice"
end
Loading