Open PR Bundle - iOS and Android to v5#145
Closed
mysport12 wants to merge 15 commits intohoxfon:masterfrom
mysport12:master
Closed
Open PR Bundle - iOS and Android to v5#145mysport12 wants to merge 15 commits intohoxfon:masterfrom mysport12:master
mysport12 wants to merge 15 commits intohoxfon:masterfrom
mysport12:master
Conversation
update build.gradle as per recommendations in RN 0.57.8 update gradle to v 3.2.1
Contributor
|
Awesome! I will test this next week. |
Collaborator
|
Thank you @mysport12 I had started working on merging already with this PR: #144 |
Author
|
Make sure you have my latest commit that includes a missed changed in the podspec. |
imajindev
reviewed
Feb 9, 2020
| private void setAudioFocus(boolean setFocus) { | ||
| if (audioManager != null) { | ||
| if (setFocus) { | ||
| savedAudioMode = audioManager.getMode(); |
There was a problem hiding this comment.
this savedAudioMode variable is not yet initialized
Collaborator
There was a problem hiding this comment.
Thank you for testing, could you please review #144 ?
That is the PR which I finally intend to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to combine a few of the open PRs into one that can be reviewed all at once to bring both iOS and Android up to v5 SDKs
Master was forked and Feat/v4 #108 was merged in
Then Android was stepped to v4 via Twilio Voice Android SDK 4 #130
iOS was brought to v5 via Feat/v4 Twilio iOS v5 #138
Then Android was brought to v5 via Twilio Voice Android SDK 5 #142
Shout outs to the original PR contributors: @fabriziomoscon @Pagebakers @lonnylot and @aniravi24 - You all did the heavy lifting. Just trying to help with the merge effort
I avoided the formatting changes wherever possible and avoided the call -> activeCall variable name change in iOS
** Note haven't had a chance to test this out yet as I am just getting started on a project that will be using this. But figured it was worth the effort to pitch in and help if possible.