feat: Android Twilio SDK 5.4.2

[fabriziomoscon]

Ported Twilio quickstart changes up to this point twilio/voice-quickstart-android@e3db03f

• notification for incoming call when the app is in the background

• implement Android v5

• test making a call

• test incoming call, when app in foreground

• test incoming call, when app in background

• test incoming call, when app is closed

• test after a call invite is cancelled, opening the JS app doesn't trigger the incoming call screen

• cleanup XML resources

• incoming notifications when the device is locked

• correctly cleanup a CALL_INVITE after answering or missed, currently the second time the app is stuck with this log:

• Error when receiving a call and the app is closed

2020-11-15 12:53:28.746 32167-32167/? W/GCM: broadcast intent callback: result=CANCELLED forIntent { act=com.google.android.c2dm.intent.RECEIVE flg=0x10000000 pkg=com.hoxfon.HoxFon.DEV.debug (has extras) }

• Ensure that issue In call dialpad not accessible when the call is answered from the lock screen #77 is resolved: In call dialpad not accessible when the call is answered from the lock screen

• add intent to call in progress notification to bring the app to the foreground

• write migration instruction in the README

Known issues:

• Call invite heads-up notification are not auto cancelled. This issue happens when a call is received and the screen is locked or the screen in unlocked, but the app is in the background. The heads-up notification service is started. If the user taps on the notification full screen content (not reject nor answer button), and then accepts the call from JS, at the end of the call the heads-up notification won't be removed, because there is no push notification for end call, just for call invite cancelled by the caller. I don't know how to solve this issue, because endForeground() can only be called by the service and all the user interactions from JS end are handled by the VoiceModule. At the same time full screen content is needed to show the JS incoming call screen when the phone is locked, therefore it can't be removed.

Reported bugs:

• getLaunchOptions() crashes upon the first app launch: feat: Android Twilio SDK 5.4.2 #164 (comment) (not able to reproduce)
• check microphone permissions: feat: Android Twilio SDK 5.4.2 #164 (comment)
• check fullscreen intent feat: Android Twilio SDK 5.4.2 #164 (comment)
• If I invoke call screen on app kill with device locked then accept call using TwilioVoice.accept() still the notification is showing after the call connect - Android version (8 , 9, 10 , 11): feat: Android Twilio SDK 5.4.2 #164 (comment)

[fmonsalvo]

@fabriziomoscon is there any reason why you are upgrading to 5.0.1 and not to 5.6.0? I'm asking since #39 depends on Android SDK being 5.3.0 or newer.

[fabriziomoscon]

@fmonsalvo I am going through all commits here: https://github.com/twilio/voice-quickstart-android/commits one by one and port them

[fmonsalvo]

Perfect, just wanted to know the rationale. I appreciate all your hard work!

[Samsritha1596]

@fabriziomoscon Hi. I have updated the Android Twilio SDK 5.0.2 code from this branch (458b0d4) and still facing same issue for incoming call.

[fabriziomoscon]

@Samsritha1596 please refer to the above checklist to see the completion stage of this PR. Currently test incoming call, when app is closed is unchecked. Note that this use case is one of the known issue with the current master branch, which PR aims to solve.

[fabriziomoscon]

@Samsritha1596 please try to use this commit: 88f4f73 and let me know if you can receive calls when the app is killed.

[Samsritha1596]

@fabriziomoscon Incoming call is not receiving when app is killed and also no events were triggered

Here is the version details:

"react-native": "0.61.5",
"react-native-twilio-programmable-voice": "^4.3.0",
"react-native-push-notification": "^6.1.3",

Please find the attached screenshot for app is killed

[Samsritha1596]

@fabriziomoscon Any update ?

[fabriziomoscon]

You are not using this PR branch

"react-native-twilio-programmable-voice": "^4.3.0"

Please use:

"react-native-twilio-programmable-voice": "https://github.com/hoxfon/react-native-twilio-programmable-voice#feat/twilio-android-sdk-5",

[Samsritha1596]

@fabriziomoscon Receives heads-up notification when app is killed and background without ringing and does not trigger any event

[fabriziomoscon]

@Samsritha1596

Receives heads-up notification when app is killed and background

This is the correct behaviour

without ringing

I don't know if the limitation for background services in Android 10 allow to ring, because they rely on the sound the user sets for notifications

does not trigger any event

This is right, because the JS app is not started, it can't deliver any event. Only tapping on ACCEPT will start the app and deliver the event to JS

[Samsritha1596]

@fabriziomoscon Behaves the same way after adding USE_FULL_SCREEN_INTENT

[fabriziomoscon]

@Samsritha1596
Please retry now, note that I pushed forced new commits.

[Samsritha1596]

@fabriziomoscon Screen does not invoke automatically when device is locked

[ro-mgh]

Hi @fabriziomoscon! I've prepared updates to this branch incl. unregistartion for Android/IOS, and I also solved an issue with "Call invite heads-up notification are not auto cancelled". Can we contact somehow to include those changes to #164 PR?

[adyra]

Hello, thanks for make this library update. I've found some issues on getAudioDevices and getSelectedAudioDevice, it returning undefined, apparently the result is not returned on method in index.js, so i make changes like this:

async getAudioDevices() {
    if (Platform.OS === IOS) {
        return
    }
    return await TwilioVoice.getAudioDevices()
},
    
async getSelectedAudioDevice() {
    if (Platform.OS === IOS) {
        return
    }
    return await TwilioVoice.getSelectedAudioDevice()
},

I also make change on method selectAudioDevice in TwilioVoiceModule.java, so when user send null param, audioSwitch will select a device automatically based on the following priority: BluetoothHeadset -> WiredHeadset -> Earpiece -> Speakerphone

@ReactMethod
public void selectAudioDevice(String name) {
    if (name != null) {
        AudioDevice selected = availableAudioDevices.get(name);
        if (selected == null) {
            return;
        }
        audioSwitch.selectDevice(selected);
    } else {
        audioSwitch.selectDevice(null);
    }
}

Also please consider to bring back method setSpeakerPhone on android, with audioSwitch we can make something like this:

@ReactMethod
public void setSpeakerPhone(Boolean value) {
  if (value) {
    AudioDevice speakerphoneDevice = availableAudioDevices.get("Speakerphone");
      if (speakerphoneDevice != null) {
          audioSwitch.selectDevice(speakerphoneDevice);
      }
  } else {
      audioSwitch.selectDevice(null);
  }
}

[julien9999]

Android 12 support + setSpeaker functionality: #211 (comment)