Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a thread race issue #224

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Fix a thread race issue #224

merged 3 commits into from
Feb 4, 2025

Conversation

houjun
Copy link
Member

@houjun houjun commented Jan 27, 2025

Related Issues / Pull Requests

#223

Description

Add mutex protection to pointer operation to fix the race condition that may cause memory error when larger than cache max size data is transferred to the server.

What changes are proposed in this pull request?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected; for instance, examples in this repository must be updated too)
  • This change requires a documentation update

Checklist:

  • My code modifies existing public API, or introduces new public API, and I updated or wrote docstrings
  • I have commented my code
  • My code requires documentation updates, and I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jeanbez jeanbez added the type: bug Something isn't working label Jan 28, 2025
@jeanbez jeanbez added this to the v.0.7 milestone Jan 28, 2025
@sbyna
Copy link
Member

sbyna commented Jan 28, 2025

@houjun Have you added the new unit tests to this?

@houjun
Copy link
Member Author

houjun commented Jan 30, 2025

@houjun Have you added the new unit tests to this?

I will add one once Perlmutter comes back.

@houjun houjun merged commit 1c78dab into stable Feb 4, 2025
8 checks passed
houjun added a commit that referenced this pull request Feb 4, 2025
houjun added a commit that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants