HPCC-27051 Create a Sasha service to clean up post-mortem files #19579
Conversation
|
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-27051 Jirabot Action Result: |
There was a problem hiding this comment.
PR Overview
This pull request adds a new configuration section for a Sasha service to clean up post-mortem files via Helm.
- Introduces a "debug-housekeeping" section under the sasha configuration.
- Sets default properties (plane and user) with additional options commented out for future adjustments.
Reviewed Changes
| File | Description |
|---|---|
| helm/hpcc/values.yaml | Adds and configures "debug-housekeeping" for the Sasha post-mortem cleanup. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
helm/hpcc/values.yaml
Outdated
| @@ -513,6 +513,14 @@ sasha: | |||
| #switchMinTime: 1 | |||
| #queues: "*" | |||
|
|
|||
| debug-housekeeping: {} # NB: no properties defined, use defaults | |||
There was a problem hiding this comment.
The inline empty map '{}' is declared for 'debug-housekeeping' and then additional properties are defined in block style. Consider removing '{}' to ensure the block values are correctly interpreted.
| debug-housekeeping: {} # NB: no properties defined, use defaults | |
| debug-housekeeping: |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
PR Overview
This PR introduces a new debug-housekeeping configuration block for the Sasha service to enable cleanup of post-mortem files. Key changes include:
- Adding a debug-housekeeping block with default and commented properties in helm/hpcc/values.yaml.
- Propagating the debug-housekeeping configuration across multiple test YAML files (values-hpcc1.yaml, values-hpcc2.yaml, multicertdomains.yaml, resourced.yaml, and resourced2.yaml).
Reviewed Changes
| File | Description |
|---|---|
| helm/hpcc/values.yaml | Added a debug-housekeeping block with a note to use defaults. |
| testing/helm/tests/values-hpcc2.yaml | Included debug-housekeeping with disabled option. |
| testing/helm/tests/multicertdomains.yaml | Included debug-housekeeping with disabled option. |
| testing/helm/tests/values-hpcc1.yaml | Included debug-housekeeping with disabled option. |
| testing/helm/tests/resourced.yaml | Added debug-housekeeping block with commented defaults and resources. |
| testing/helm/tests/resourced2.yaml | Added debug-housekeeping block with commented defaults and resources. |
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
helm/hpcc/values.yaml:516
- The indentation of the properties under the debug-housekeeping key appears inconsistent; please verify that when uncommented, the properties are correctly nested.
debug-housekeeping: {} # NB: no properties defined, use defaults
testing/helm/tests/resourced.yaml:514
- [nitpick] Consider removing or clearly delineating the commented-out default properties in the debug-housekeeping block to avoid potential confusion during maintenance.
debug-housekeeping:
There was a problem hiding this comment.
PR Overview
This pull request adds a new debug‐housekeeping configuration to the Sasha service intended for cleaning up post‐mortem files. It updates the Helm chart values and test configuration files to introduce the new setting with different defaults in production versus test environments.
- Added a debug-housekeeping block with commented default properties in helm/hpcc/values.yaml.
- Inserted explicit disabled settings for debug-housekeeping in various test YAML files.
- Extended debug-housekeeping in some tests to include resource configuration options.
Reviewed Changes
| File | Description |
|---|---|
| helm/hpcc/values.yaml | Added debug-housekeeping with an empty object and commented defaults. |
| testing/helm/tests/multicertdomains.yaml | Added debug-housekeeping with disabled set to true. |
| testing/helm/tests/values-hpcc1.yaml | Added debug-housekeeping with disabled set to true. |
| testing/helm/tests/values-hpcc2.yaml | Added debug-housekeeping with disabled set to true. |
| testing/helm/tests/resourced.yaml | Introduced debug-housekeeping with commented defaults and resource settings. |
| testing/helm/tests/resourced2.yaml | Introduced debug-housekeeping with commented defaults and resource settings. |
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
helm/hpcc/values.yaml
Outdated
| debug-housekeeping: {} # NB: no properties defined, use defaults | ||
| #disabled: true |
There was a problem hiding this comment.
The production values define debug-housekeeping as an empty object with commented defaults, while test configs explicitly disable it; this inconsistency may lead to unexpected behavior. Consider standardizing the default settings or explicitly documenting the differences between production and test environments.
| debug-housekeeping: {} # NB: no properties defined, use defaults | |
| #disabled: true | |
| debug-housekeeping: | |
| disabled: true |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| disabled: true | ||
|
|
There was a problem hiding this comment.
The debug-housekeeping key is introduced with 'disabled: true' in this test file, which does not match the production configuration. Aligning these default settings can help avoid configuration drift between environments.
| disabled: true | |
| disabled: false |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
testing/helm/tests/resourced.yaml
Outdated
| @@ -510,6 +510,16 @@ sasha: | |||
| resources: | |||
| cpu: "1" | |||
| memory: "4Gi" | |||
|
|
|||
| debug-housekeeping: | |||
There was a problem hiding this comment.
This instance of debug-housekeeping includes additional nested resource settings, differing from other configurations. Consider unifying the configuration across files to prevent confusion.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
testing/helm/tests/resourced2.yaml
Outdated
| @@ -512,6 +512,16 @@ sasha: | |||
| resources: | |||
| cpu: "1" | |||
| memory: "4Gi" | |||
|
|
|||
| debug-housekeeping: | |||
There was a problem hiding this comment.
The debug-housekeeping block here also contains resource settings that differ from the defaults in production. Standardize the configuration or clearly document the different behaviors between environments.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
PR Overview
This PR implements configuration changes to support a Sasha service that cleans up post-mortem files by introducing a new debug-housekeeping configuration. The changes add debug-housekeeping settings to various Helm configuration files for both production and testing environments.
- Added a debug-housekeeping block with placeholder parameters in helm/hpcc/values.yaml.
- Enabled debug-housekeeping (set to disabled) in testing configuration files.
- Added resource allocation settings under debug-housekeeping in resourced and resourced2 test files.
Reviewed Changes
| File | Description |
|---|---|
| helm/hpcc/values.yaml | Introduces a new debug-housekeeping block with default parameters commented out. |
| testing/helm/tests/values-hpcc2.yaml | Enables debug-housekeeping by setting disabled to true. |
| testing/helm/tests/values-hpcc1.yaml | Enables debug-housekeeping by setting disabled to true. |
| testing/helm/tests/multicertdomains.yaml | Enables debug-housekeeping by setting disabled to true. |
| testing/helm/tests/resourced.yaml | Adds a debug-housekeeping block with resource allocations and commented defaults. |
| testing/helm/tests/resourced2.yaml | Similar addition of debug-housekeeping with resource allocations and commented defaults. |
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
There was a problem hiding this comment.
PR Overview
This PR adds a new configuration option ("debug-housekeeping") to enable additional housekeeping behaviors for the Sasha service, intended to help clean up post-mortem files. Key changes include:
- Adding a "debug-housekeeping" section with default (empty or disabled) configuration in helm/hpcc/values.yaml.
- Introducing similar "debug-housekeeping" blocks in multiple test files (values-hpcc1.yaml, multicertdomains.yaml, values-hpcc2.yaml, resourced2.yaml, resourced.yaml) for consistency.
Reviewed Changes
| File | Description |
|---|---|
| helm/hpcc/values.yaml | Added a "debug-housekeeping" option with commented default properties. |
| testing/helm/tests/values-hpcc1.yaml | Added a "debug-housekeeping" block with "disabled: true" setting. |
| testing/helm/tests/multicertdomains.yaml | Similar addition of a "debug-housekeeping" block with "disabled: true". |
| testing/helm/tests/values-hpcc2.yaml | Similar addition of a "debug-housekeeping" block with "disabled: true". |
| testing/helm/tests/resourced2.yaml | Added a "debug-housekeeping" block including a nested "resources" block. |
| testing/helm/tests/resourced.yaml | Added a "debug-housekeeping" block including a nested "resources" block. |
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
helm/hpcc/values.yaml:516
- Ensure that the commented configuration lines below maintain consistent indentation if uncommented to avoid YAML parsing issues.
debug-housekeeping: {} # NB: no properties defined, use defaults
testing/helm/tests/resourced2.yaml:522
- Confirm that 'resources' is intentionally nested under 'debug-housekeeping' in this file and that its usage is consistent with other configurations.
resources:
testing/helm/tests/resourced.yaml:520
- Confirm that 'resources' is intentionally nested under 'debug-housekeeping' in this file and that its usage is consistent with other configurations.
resources:
Type of change:
Checklist:
Smoketest:
Testing: