Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC4J-623 Need to read addl int before close() #730

Merged

Conversation

mckellyln
Copy link
Contributor

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@mckellyln
Copy link
Contributor Author

@jpmcmu this is the change I mentioned before to prevent strange/extraneous closed socket messages in the dafilesrv logs.

@mckellyln mckellyln force-pushed the read_int_before_close branch from 2130c56 to 5f15250 Compare August 1, 2024 12:03
@mckellyln mckellyln changed the title HPCC-00000 Need to read addl int before close() HPCC4J-623 Need to read addl int before close() Aug 1, 2024
@jpmcmu
Copy link
Contributor

jpmcmu commented Aug 1, 2024

@mckellyln Thanks for the PR. Looks good to me

@rpastrana rpastrana requested a review from jpmcmu August 1, 2024 12:58
@rpastrana rpastrana merged commit 1834b0c into hpcc-systems:candidate-9.2.x Aug 1, 2024
3 of 6 checks passed
Copy link

github-actions bot commented Aug 1, 2024

Jirabot Action Result:
Added fix version: 9.2.110
Added fix version: 9.4.84
Added fix version: 9.6.36
Added fix version: 9.8.10
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants