Skip to content

HPCC4J-797 Index Write Support - #987

Open
jpmcmu wants to merge 4 commits into
hpcc-systems:candidate-10.2.xfrom
jpmcmu:HPCC4J-797
Open

HPCC4J-797 Index Write Support#987
jpmcmu wants to merge 4 commits into
hpcc-systems:candidate-10.2.xfrom
jpmcmu:HPCC4J-797

Conversation

@jpmcmu

@jpmcmu jpmcmu commented Mar 30, 2026

Copy link
Copy Markdown
Contributor
  • Added support for writing indexes

Signed-off-by: James McMullan James.McMullan@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Custom Platform Testing (Optional)

Custom HPCC-Platform Repository:
repository:

Custom HPCC-Platform Branch:
branch:

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

- Added support for writing indexes

Signed-off-by: James McMullan James.McMullan@lexisnexis.com
@jpmcmu
jpmcmu requested a review from Copilot March 30, 2026 13:21
@github-actions

Copy link
Copy Markdown

Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-797

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@github-actions

Copy link
Copy Markdown

🔄 Upmerge Test Results

Status: ✅ All branches merged successfully
PR: #987 - HPCC4J-797 Index Write Support
Base Branch: candidate-10.2.x
Test Time: 2026-03-30 13:41:51 UTC

✅ Successful Branches (2)

  • candidate-10.2.x
  • master
    This comment was automatically generated by the upmerge test workflow.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds DFS client support for writing HPCC index file parts via rowservice (including index-specific compression options) and introduces a remote test that exercises index creation + publish.

Changes:

  • Extend RowServiceOutputStream/HPCCRemoteFileWriter to support index writes (separate input vs output record definitions; index compression validation).
  • Add index-specific CompressionAlgorithm enum values and expose index-related field flags via FieldDef.
  • Add a new remote test that writes and publishes an index (writeIndexTest).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
dfsclient/src/test/java/org/hpccsystems/dfs/client/DFSIndexTest.java Adds a remote test that writes an index using the DFS writer + DFU publish flow.
dfsclient/src/main/java/org/hpccsystems/dfs/client/RowServiceOutputStream.java Adds a stream context + indexwrite request support in the rowservice open/write handshake.
dfsclient/src/main/java/org/hpccsystems/dfs/client/HPCCRemoteFileWriter.java Wires new rowservice stream context into the writer and adds output-record support for index files.
dfsclient/src/main/java/org/hpccsystems/dfs/client/CompressionAlgorithm.java Adds index-specific compression algorithm values and a helper to identify index compression.
commons-hpcc/src/main/java/org/hpccsystems/commons/ecl/RecordDefinitionTranslator.java Removes a retained-flag constant (moved/centralized elsewhere).
commons-hpcc/src/main/java/org/hpccsystems/commons/ecl/FieldDef.java Introduces public flags for biased/payload fields used in index layouts.

Comment thread dfsclient/src/test/java/org/hpccsystems/dfs/client/DFSIndexTest.java Outdated
Comment thread dfsclient/src/test/java/org/hpccsystems/dfs/client/DFSIndexTest.java Outdated
Comment thread dfsclient/src/main/java/org/hpccsystems/dfs/client/RowServiceOutputStream.java Outdated
Comment thread dfsclient/src/main/java/org/hpccsystems/dfs/client/RowServiceOutputStream.java Outdated
Comment thread dfsclient/src/main/java/org/hpccsystems/dfs/client/RowServiceOutputStream.java Outdated
Comment thread dfsclient/src/test/java/org/hpccsystems/dfs/client/DFSIndexTest.java Outdated
Comment thread dfsclient/src/main/java/org/hpccsystems/dfs/client/RowServiceOutputStream.java Outdated
Comment thread dfsclient/src/test/java/org/hpccsystems/dfs/client/DFSIndexTest.java Outdated
Comment thread dfsclient/src/test/java/org/hpccsystems/dfs/client/DFSIndexTest.java Outdated
Comment thread dfsclient/src/test/java/org/hpccsystems/dfs/client/DFSIndexTest.java Outdated
Comment thread dfsclient/src/test/java/org/hpccsystems/dfs/client/DFSIndexTest.java Outdated
@jpmcmu
jpmcmu requested a review from Copilot April 2, 2026 13:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Comment thread dfsclient/src/main/java/org/hpccsystems/dfs/client/BinaryRecordWriter.java Outdated
Comment thread commons-hpcc/src/test/java/org/hpccsystems/commons/ecl/RecordDefinitionTests.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants