HPCC4J-797 Index Write Support - #987
Open
jpmcmu wants to merge 4 commits into
Open
Conversation
- Added support for writing indexes Signed-off-by: James McMullan James.McMullan@lexisnexis.com
|
Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-797 Jirabot Action Result: |
🔄 Upmerge Test ResultsStatus: ✅ All branches merged successfully ✅ Successful Branches (2)
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds DFS client support for writing HPCC index file parts via rowservice (including index-specific compression options) and introduces a remote test that exercises index creation + publish.
Changes:
- Extend
RowServiceOutputStream/HPCCRemoteFileWriterto support index writes (separate input vs output record definitions; index compression validation). - Add index-specific
CompressionAlgorithmenum values and expose index-related field flags viaFieldDef. - Add a new remote test that writes and publishes an index (
writeIndexTest).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| dfsclient/src/test/java/org/hpccsystems/dfs/client/DFSIndexTest.java | Adds a remote test that writes an index using the DFS writer + DFU publish flow. |
| dfsclient/src/main/java/org/hpccsystems/dfs/client/RowServiceOutputStream.java | Adds a stream context + indexwrite request support in the rowservice open/write handshake. |
| dfsclient/src/main/java/org/hpccsystems/dfs/client/HPCCRemoteFileWriter.java | Wires new rowservice stream context into the writer and adds output-record support for index files. |
| dfsclient/src/main/java/org/hpccsystems/dfs/client/CompressionAlgorithm.java | Adds index-specific compression algorithm values and a helper to identify index compression. |
| commons-hpcc/src/main/java/org/hpccsystems/commons/ecl/RecordDefinitionTranslator.java | Removes a retained-flag constant (moved/centralized elsewhere). |
| commons-hpcc/src/main/java/org/hpccsystems/commons/ecl/FieldDef.java | Introduces public flags for biased/payload fields used in index layouts. |
rpastrana
reviewed
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James McMullan James.McMullan@lexisnexis.com
Type of change:
Custom Platform Testing (Optional)
Custom HPCC-Platform Repository:
repository:
Custom HPCC-Platform Branch:
branch:
Checklist:
Testing: