Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add localize function to input box title and place holder #413

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: add localize function to input box title and place holder #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/notebook/controller/command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as vscode from "vscode";
import localize from "../../util/localize";
import { serializer } from "./serializer";

export let commands: Commands;
Expand Down Expand Up @@ -57,7 +58,7 @@ export class Commands {
async cellName(cell: vscode.NotebookCell) {
const node = serializer.node(cell);
node.name = node.name ?? "";
const name = await vscode.window.showInputBox({ value: node.name, title: "Result Name", placeHolder: "Result Name" });
const name = await vscode.window.showInputBox({ value: node.name, title: localize("Result Name"), placeHolder: localize("Result Name") });
if (name !== undefined) {
node.name = name;
}
Expand All @@ -72,7 +73,7 @@ export class Commands {
name: "",
...node?.data?.source,
};
const name = await vscode.window.showInputBox({ value: data.source.name, title: "Database Name", placeHolder: "Database Name" });
const name = await vscode.window.showInputBox({ value: data.source.name, title: localize("Database Name"), placeHolder: localize("Database Name") });
if (name !== undefined) {
data.source.name = name;
node.data = data;
Expand Down
Loading