feat: Add preferredECLWatch setting#439
Merged
GordonSmith merged 1 commit intohpcc-systems:trunkfrom Feb 25, 2025
Merged
Conversation
jeclrsg
reviewed
Feb 25, 2025
Collaborator
jeclrsg
left a comment
jeclrsg
left a comment
There was a problem hiding this comment.
@GordonSmith didn't notice any issues in the code, just a handful of typos "preffered" vs "preferred"
README.md
Outdated
| ## Recent Highlights | ||
|
|
||
| ### v2.30.x | ||
| * Added `ecl.preferredECLWatch` setting, allows user to nominate preffered version of ECL Watch when opening "external" pages. |
Collaborator
There was a problem hiding this comment.
typo, should be "preferred"
README.md
Outdated
| // Ping interval (secs, -1 to disable) | ||
| "ecl.pingInterval": 5 | ||
|
|
||
| // Preffered version of ECL Watch (default v9). |
Collaborator
There was a problem hiding this comment.
typo, should be "preferred"
package.json
Outdated
| "v5" | ||
| ], | ||
| "default": "v9", | ||
| "description": "%Preffered version of ECL Watch%" |
Collaborator
There was a problem hiding this comment.
typo, should be "preferred"
package.nls.json
Outdated
| "Pin launch configuration to current document": "Pin launch configuration to current document", | ||
| "Ping interval (secs, -1 to disable)": "Ping interval (secs, -1 to disable)", | ||
| "Pinned launch configurations": "Pinned launch configurations", | ||
| "Preffered version of ECL Watch": "Preffered version of ECL Watch", |
Collaborator
There was a problem hiding this comment.
typo, should be "preferred"
fixes hpcc-systems#438 Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
GordonSmith
force-pushed
the
WU_MENU_FIXUP
branch
from
0c2689b to
f0d9fed
Compare
jeclrsg
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #438