chore: update langchain dependencies and refactor SimilarityModel#500
chore: update langchain dependencies and refactor SimilarityModel#500GordonSmith merged 1 commit intohpcc-systems:mainfrom
Conversation
5879e30 to
7155b43
Compare
There was a problem hiding this comment.
Pull request overview
This PR upgrades the LangChain dependency stack to the v1.x packages and adjusts the extension’s SimilarityModel implementation to the new vector store import path, alongside adding a unit test intended to validate SimilarityModel behavior under the updated dependencies.
Changes:
- Bump LangChain-related packages (
@langchain/*,langchain) to v1.x. - Refactor
src/ecl/docs/SimilarityModel.tsto importMemoryVectorStorefrom@langchain/classic. - Add a SimilarityModel test and update Vitest configuration to run it.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
vitest.config.ts |
Updates Vitest test allow-list to include the new SimilarityModel test. |
test/SimilarityModel.test.ts |
Adds test coverage around SimilarityModel/store loading behavior (and/or dependency compatibility). |
src/ecl/docs/SimilarityModel.ts |
Switches MemoryVectorStore import to @langchain/classic for LangChain v1 compatibility. |
package.json |
Upgrades LangChain packages to v1.x. |
package-lock.json |
Lockfile refresh for the dependency upgrades. |
d9ff168 to
ba79f66
Compare
jeclrsg
left a comment
There was a problem hiding this comment.
@GordonSmith does that current SimilarityModel test file contain any useful tests?
There was a problem hiding this comment.
Shouldn't this be testing LlamaEmbeddings from SimilarityModel? It seems like it's currently just testing if the langchain does what it's supposed to.
Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
ba79f66 to
bdfa736
Compare
|
🎉 This change has been included in ecl-v2.37.0 🎉 The release is available on:
Your release-please bot 🚀🙏 |
No description provided.