Skip to content

chore: update langchain dependencies and refactor SimilarityModel#500

Merged
GordonSmith merged 1 commit intohpcc-systems:mainfrom
GordonSmith:BUMP_LANGCHAIN
Feb 13, 2026
Merged

chore: update langchain dependencies and refactor SimilarityModel#500
GordonSmith merged 1 commit intohpcc-systems:mainfrom
GordonSmith:BUMP_LANGCHAIN

Conversation

@GordonSmith
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the LangChain dependency stack to the v1.x packages and adjusts the extension’s SimilarityModel implementation to the new vector store import path, alongside adding a unit test intended to validate SimilarityModel behavior under the updated dependencies.

Changes:

  • Bump LangChain-related packages (@langchain/*, langchain) to v1.x.
  • Refactor src/ecl/docs/SimilarityModel.ts to import MemoryVectorStore from @langchain/classic.
  • Add a SimilarityModel test and update Vitest configuration to run it.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
vitest.config.ts Updates Vitest test allow-list to include the new SimilarityModel test.
test/SimilarityModel.test.ts Adds test coverage around SimilarityModel/store loading behavior (and/or dependency compatibility).
src/ecl/docs/SimilarityModel.ts Switches MemoryVectorStore import to @langchain/classic for LangChain v1 compatibility.
package.json Upgrades LangChain packages to v1.x.
package-lock.json Lockfile refresh for the dependency upgrades.

@GordonSmith GordonSmith force-pushed the BUMP_LANGCHAIN branch 2 times, most recently from d9ff168 to ba79f66 Compare February 12, 2026 08:46
Copy link
Collaborator

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith does that current SimilarityModel test file contain any useful tests?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be testing LlamaEmbeddings from SimilarityModel? It seems like it's currently just testing if the langchain does what it's supposed to.

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith merged commit 6d188d7 into hpcc-systems:main Feb 13, 2026
4 checks passed
@GordonSmith GordonSmith deleted the BUMP_LANGCHAIN branch February 13, 2026 10:11
@github-actions
Copy link
Contributor

🎉 This change has been included in ecl-v2.37.0 🎉

The release is available on:

Your release-please bot 🚀🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants