Improved element size rendering #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| self isRelativeSize: aCSSProperty propertyString ifTrue: [ | ||
| "hope it's percent" |
There was a problem hiding this comment.
Should later be changed: Percent should be relative to the parent's width, em and ex should be relative to the local font size.
For now I wouldn't implement this, but defer to #145
|
Currently, we lost a functionality: You cannot open google search results anymore |
| @@ -0,0 +1,4 @@ | |||
| layout | |||
| adjustBoundsToSubmorphs | |||
|
|
|||
There was a problem hiding this comment.
Maybe add a comment here why this returns false? Tables normally (within limits) adjust to their contents' sizes.
|
Apart from the bug @JenniferStamm already mentioned (according non-clickable links) this can be ⛵ed |
| | submorphCorner delta | | ||
| submorphCorner := self submorphs | ||
| ifEmpty: [ self position + self computedSize ] | ||
| ifNotEmpty: [ ((self submorphBounds origin extent: self computedSize) quickMerge: self submorphBounds) corner asIntegerPoint ]. |
There was a problem hiding this comment.
This line is kind of long
JenniferStamm
added a commit
that referenced
this pull request
Jul 5, 2014
Improved element size rendering
This was referenced Jul 5, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not actually an implementation of box-model yet - block element widths fill all available space, and the document height is also at least the height of the WebPageMorph.