New rendering pipeline #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me. I am still trying to think of a meaningful test, but have not yet been successful. But so far: ⛵ |
|
Works for me as well 🐬 |
PFischbeck
added a commit
that referenced
this pull request
Jun 5, 2014
Close #75: New rendering pipeline
|
The methods |
|
Those are known issues that we have not yet dealt with, because those methods haven't been used by us so far. But this has to be done, therefore: #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think, it's ready for prime time 😉
There are no tests yet, maybe we should add at least some until thursday.
The Tanzmaus-Image (http://de.selfhtml.org/html/grafiken/anzeige/img.htm) is still not displayed correctly - this seems to be unrelated to the new pipeline, and I'm not sure, what the problem is in detail.
(It probably has to do with embedding submorphs in the TextMorph and their positioning: BitBltDisplayScanner>>placeEmbeddedObject:)
If problems with displaying images occur more frequently, we should make a bug/user story out of it, but I've not seen any other websites with this problem yet.