Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use line modification probability in typos #51

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

eu9ene
Copy link
Contributor

@eu9ene eu9ene commented Feb 7, 2024

fixes #49

@eu9ene
Copy link
Contributor Author

eu9ene commented Feb 7, 2024

The typos tests don't pass locally even without a fix. I wonder if they're broken or it's just randomization works differently in my local env

@eu9ene eu9ene marked this pull request as ready for review February 7, 2024 23:50
@eu9ene
Copy link
Contributor Author

eu9ene commented Feb 8, 2024

I figured this out. The random values are different now because of the extra call of random.randit, so I had to update the expected values for all tests that use typos.

@jelmervdl jelmervdl merged commit 4fceac9 into hplt-project:main Feb 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typos modifier does not use 'probability' parameter
2 participants