Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes from pypy #482

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes from pypy #482

wants to merge 1 commit into from

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Jan 22, 2025

  • add proper function declarations
  • skip a few tests that fail on PyPy

I found these when updating PyPy to work with latest HEAD here. It might be nice to release 0.9.1 so there is a tag to use for the cython benchmarks at https://github.com/DuToitSpies/msc_cython_benchmarks

@mattip
Copy link
Contributor Author

mattip commented Jan 22, 2025

The image changed to ubuntu24.04 and now python3.10 installation is different?

sudo apt-get install -y --no-install-recommends python3.10-dev python3.10-venv python3-distutils python3.10-dbg
  Reading package lists...
  Building dependency tree...
  Reading state information...
  Package python3-distutils is not available, but is referred to by another package.
  This may mean that the package is missing, has been obsoleted, or
  is only available from another source

@mattip
Copy link
Contributor Author

mattip commented Jan 22, 2025

And on windows, the build also fails

D:\a\hpy\hpy\hpy\universal\src\autogen_ctx_def.h(181): \
    error C2220: the following warning is treated as an error
  D:\a\hpy\hpy\hpy\universal\src\autogen_ctx_def.h(181): \
                     warning C4113: 'void (__cdecl *)(HPyContext *,HPyFunc_Signature,void *(__cdecl *)(),void *)' 
    differs in parameter lists from 'void (__cdecl *)(HPyContext *,HPyFunc_Signature,HPyCFunction,void *)'
  error: command 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.42.34433\\bin\\HostX86\\x64\\cl.exe' failed with exit code 2

Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants