Improve HID report parsing and safety checks #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add report length validation in get_report_value() - Enhance report ID handling in extract_report_values() - Reset bit offset when changing report ID in parser - Add bounds checking to prevent potential buffer overruns
rygwdn
force-pushed
the
fix-multiple-report-ids
branch
from
dba5a85 to
32305f1
Compare
|
Thank you for this, great catch! I was assuming the setting offset_in_bits to 0 between top-level collections would be enough, but seem to have forgotten about the possibility of new report IDs being introduced. Let me do some testing and pull this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #218 and possibly #133