Skip to content

Good practice #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Good practice #259

merged 2 commits into from
Sep 6, 2022

Conversation

hageboeck
Copy link
Contributor

To continue on #78, here's a draft of a recognisable good practice box. What's missing is the "index of good practices". I need to learn a bit more on the deeper tex mechanics to do this cleanly.
The new environment will in the future "just" create that index automatically.

@hageboeck hageboeck self-assigned this Sep 6, 2022
talk/setup.tex Outdated
@@ -31,6 +31,9 @@
\end{beamercolorbox}%
}

\setbeamercolor{goodpractice head}{fg=white,bg=orange}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
\setbeamercolor{goodpractice head}{fg=white,bg=orange}
\setbeamercolor{goodpractice head}{fg=white,bg=orange!50!black}

Or something of this kind, that is more dark so that the white writing is easier to read

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

orange!50!black:
image

orange!90!black:
image

Current head:
image

Opinions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some 70-80 ? so that it stays orange (and not brown) but slightly darker. Actually the 90 is not bad already

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

85 now. I will merge, and we can tweak it once we see the slides on a projector.

@bernhardmgruber
Copy link
Contributor

Awesome, this streamlines our best practices nicely!

Usage:
\begin{goodpractice}{<Title>}
  <body>
\end{goodpractice}

This creates a box titled "Good practice: <Title>", so <Title> could be
- Pass by reference
- Use of locks
etc.
@hageboeck hageboeck merged commit f456cd3 into hsf-training:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants