Skip to content

Tiny fixes after rehearsal of advanced course #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2022
Merged

Tiny fixes after rehearsal of advanced course #324

merged 1 commit into from
Oct 11, 2022

Conversation

sponce
Copy link
Contributor

@sponce sponce commented Oct 10, 2022

things like fixing line numbers, missing semi-colon.

Only 2 real changes :

  • constinit slide
  • dynamic_cast example

bernhardmgruber
bernhardmgruber requested changes Oct 10, 2022
View reviewed changes
bernhardmgruber
bernhardmgruber approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@bernhardmgruber bernhardmgruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check the numbering of code snippets. The rest looks good!

@sponce sponce merged commit 47defb0 into master Oct 11, 2022
@sponce sponce deleted the sponce_fixes branch October 12, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernhardmgruber bernhardmgruber bernhardmgruber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sponce @bernhardmgruber