Secondary entry points to allow better dead-code elimination #4628

FilipLeitner · 2024-01-11T12:45:45Z

Description

As described in #4616

Related issues or pull requests

closes #4616

Pull request type

Please check the type of change your PR introduces:

Do you introduce a breaking change?

Yes
No
I am unsure (no worries, we'll find out)

Checklist

I understand and agree that the changes in this PR will be licensed under the [MIT License]
I have followed the guidelines for contributing
The proposed change fits to the content of the code of conduct
I have added or updated tests and documentation, and the test suite passes (run npm test locally)
I'm lost; why do I have to check so many boxes? Please help!

FilipLeitner · 2024-01-11T13:15:28Z

hslayers-app should be loading much quicker - its not possible to treeshake the code as we dont know whats gonna be required but with each component having separate chunk the browser will get only whats necessary based on config.panelsEnabled and config.componentsEnabled
in 'full app' or app that use hslayers-ng library from npm have different options (described briefly in decouple-test-app project)
a) treeshake unused code by importing only whats necessary - code will end up in main.js

b) Use same technique as used in hslayers-app
c) possibly combination of both eg. dynamic imports in container app directly

Most of the work has been completed.

TBD:

hslayers component is basically of no use right now as I was mostly evading imports from main entry point hslayers. It needs to be tested wether it causes apps to bundle whole hslayers (becasue of barel public-api) file or it still can be use along with the principles described above.... If it will be usable we might probably merge it with layout component as we wont need both,
~~Otherwise setting of a config and app id should work without necessity of using hslayers component.~~
~~try make dependencies entry-point speciffic if possible** eg. allow container app to be compiled with deps that it really needs only~~
some sort of API adjustments and cleanup of project structure as this wasnt really thought through
~~cesium update~~
~~possibly remove hslayers-material~~

FilipLeitner · 2024-01-12T12:53:38Z

Few new changes.:

deprecated layout module in favor of hslayers module which basically took on all of the responsibilites of layout module
removed exports from barel main entry poublic-api -> imports will be available from secondary entries only (hslayers component is an exception obviously)
- As a result components will not be loaded automatically jsut by adding hslayers element to app template. Separate construction methods or manual setup is necessary . The reason is that we would not be able to have both of the options available in case the files with dynamic imports are always present in a bundle
made queryPopup a standalone entrypoint so we dont always import all of query if popus are wanted
NEW CONFIG VALUE: componentsEnabled.queryPopup which controls whether a popup functionality will be avilable
tested vendor treeshaking a bit and it seem to be reacting somehow out of the box. Some unexpected libraries ended up in bundle of reasonanly stripped app - geostylers, loadsh but for example polygon-splitter was not there. Will have to investigate further

FilipLeitner · 2024-01-19T09:21:07Z

hslayers-ng bundle part size comparison for https://www.agrihub.cz/hsl-ng/AgroClima/
(percentages are not really usable as´"before" app vendors were split somehow, to satisfy webpack hModuleFederation eg. significant part is not included in the same bundle as hsl.

…mponents

Use ngIf instead of hidden and simplify value calculation

BREAKING CHANGE: query component (info panel) renamed to query, info component (compositionLoadingProgress) renamed to info and configuration moved from panels to components

…ix lang load

Less verbose internal panels creation Expose single method for creating external panels with and sb buttons

…mponents Align layerm-manager files with naming convention of the repo BREAKING CHANGE: panelsEnabled options renamed

@defer

refactor: Remove @defer usage as currently it doesnt allow treeshaking of the component

build: Improve treeshakability of print component

fix: Print imports

Code distribution changes from per component to chunk per panel

In contrast with chunk create by less verbose approach + max chunk number plugin content of these chunks are not mixed

fix(sensors): Panel visiblity refactor: No panel enabled check necessary when switching panels Only active panels are available

The folder for sub-entrypoints MUST be next to the src folder https://stackoverflow.com/questions/74012408/using-single-component-from-library-causes-lazy-loaded-modules-to-end-up-in-main

Add config option toggling the component - componentsEnabled.queryPopup

Use hslayers element/module instaed of layout

Use hslayers component and remove comments about popups

Move types out of common

Saves around 100kb of chunk size eg 5%

jmacura

I am leaving some comments, but propose to only solve the typos in this PR and to look at the rest at some consecutive PRs so this doesn't grow indefinitely.

projects/hslayers/common/panels/gui-overlay-base.component.ts

projects/hslayers/components/print/print.component.html

projects/hslayers/components/measure/measure.module.ts

projects/hslayers/components/sidebar/sidebar.component.ts

projects/hslayers/shared/panel-constructor/panel-constructor.service.ts

projects/hslayers/shared/sidebar/sidebar.service.ts

projects/hslayers/src/hslayers.component.ts

projects/test-app/src/hslayers-app/some-panel/some-panel.component.html

jmacura · 2024-02-12T23:53:46Z

projects/hslayers/shared/add-data/url/hs.source.WfsSource.ts

Why this files goes into shared? This is not a service. Is it because it requires services in its constructor?

Exactly, its imported only via wfs.service which is in the same entry point as this file. Circular dependencies are more strict than we were used to before. Once you have import from shared/add-data in components/add-data you can not go the other way around. Even for totaly separate files.

jmacura · 2024-02-13T00:09:52Z

FTR, this PR also removes hlayers-material, an HSLayers-NG version with Material Design.

Co-authored-by: jmacura <[email protected]>

FilipLeitner requested a review from jmacura as a code owner January 11, 2024 12:45

FilipLeitner marked this pull request as draft January 11, 2024 12:46

FilipLeitner mentioned this pull request Jan 12, 2024

Defer load #4552

Closed

17 tasks

FilipLeitner force-pushed the secondary-entry branch from f4c8b21 to 028ac38 Compare January 15, 2024 07:52

FilipLeitner linked an issue Jan 15, 2024 that may be closed by this pull request

Resurrect hslayers-material #2338

Closed

FilipLeitner marked this pull request as ready for review January 15, 2024 12:42

FilipLeitner force-pushed the secondary-entry branch from 58f220f to 7e7a1be Compare January 16, 2024 10:48

FilipLeitner mentioned this pull request Jan 17, 2024

WMS metadata extent parsing, Option to add WMS layers as one group or separate layers #4639

Merged

17 tasks

FilipLeitner added 19 commits January 22, 2024 10:50

refactor(panels): Create sidebar panel buttons from outside of the co…

b5104b2

…mponents

refactor: Main panel visiblity

c030174

Use ngIf instead of hidden and simplify value calculation

refactor: Use panelBaseComponent method to set width of panels

2bf7dcb

refactor: GUI components visibility

91ffff1

BREAKING CHANGE: query component (info panel) renamed to query, info component (compositionLoadingProgress) renamed to info and configuration moved from panels to components

refactor: Add tripPlaner button to sidebarDefs, fix decoupling app, f…

ad0f376

…ix lang load

refator: Create panel components

fb371b7

Less verbose internal panels creation Expose single method for creating external panels with and sb buttons

refactor: Align panel,componentm folder and config names for panel co…

38f423e

…mponents Align layerm-manager files with naming convention of the repo BREAKING CHANGE: panelsEnabled options renamed

fix: Minisidebar visiblity

3df9197

refactor: Remove @defer usage as currently it doesnt allow treeshaking of the component

fix(sensors): Adjust to changes

f3e8cf2

refactor(styler): Align naming of folder and component

c45a414

fix:Decoupling test app

631d190

build: Improve treeshakability of print component

test: Fix tests

cae8bcf

fix: Print imports

build(decouplin-app): Optimize chunk number

5b494c7

refactor(panel-constructor): Verbose approach for panel creating

78d1f93

Code distribution changes from per component to chunk per panel

perf(decoupling): Split panel chunks into smaller parts

cc10157

In contrast with chunk create by less verbose approach + max chunk number plugin content of these chunks are not mixed

refactor(overlay): Expose GUI overlay creation as a function

c392e72

build(app): Use 'decoupling' method to build hslayers-app

d27610c

fix(sensors): Panel visiblity refactor: No panel enabled check necessary when switching panels Only active panels are available

refactor: Move common, components and cofig out of src

a82b32f

The folder for sub-entrypoints MUST be next to the src folder https://stackoverflow.com/questions/74012408/using-single-component-from-library-causes-lazy-loaded-modules-to-end-up-in-main

refactor: Update imports among entrypoints

9bc64ce

FilipLeitner added 21 commits January 22, 2024 10:51

build: Decoupling app

528e71e

build: Test-app

69d7976

fix: Close tag in add-data - merge mistake

571107f

chore: Add decoupling test app build script

3981a3a

build: Isolate query-popup

973c4a9

Add config option toggling the component - componentsEnabled.queryPopup

fix: Register popUp on map

0cc8057

refactor: Depreacate components/layout in favor of hslayers component

f5fd17c

refactor: hslayers-app

adf794f

Use hslayers element/module instaed of layout

refactor: Decoupling test app

5a6d6c5

Use hslayers component and remove comments about popups

test: Fix hslayers component test

e149a10

build: hslayers-ng/types

c51084d

Move types out of common

fix: Set permissions success callback

7329331

fix: Import layer table into modules

07d44fa

fix: Set permissions success callback

7300caf

fix: Add missing standalone directive import

5e5c833

fix: Panel-header viewchild value race condition

7237aeb

refactor: Remove unused imports from hslayers component

bb8b838

build: Deprecate angular material project

887d8bf

build: Update imports in cesium

ee33f26

build:Remove jszip from initial vendor chunk using dynamic jszip import

253c5da

Saves around 100kb of chunk size eg 5%

test: Fix e2e tests and issues connected with them

1c30d01

FilipLeitner force-pushed the secondary-entry branch from a201a1c to 1c30d01 Compare January 22, 2024 09:51

jmacura approved these changes Feb 13, 2024

View reviewed changes

FilipLeitner and others added 3 commits February 13, 2024 10:57

chore: Correct typos

e39cbda

Co-authored-by: jmacura <[email protected]>

refactor: Remove defers from print component as they are of no use atm

cf51a24

chore: Remove unused core module

64e871d

FilipLeitner force-pushed the secondary-entry branch from 0e9c915 to 64e871d Compare February 13, 2024 09:58

jmacura approved these changes Feb 13, 2024

View reviewed changes

jmacura merged commit 4684e14 into develop Feb 13, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Secondary entry points to allow better dead-code elimination #4628

Secondary entry points to allow better dead-code elimination #4628

FilipLeitner commented Jan 11, 2024 •

edited

Loading

FilipLeitner commented Jan 11, 2024 •

edited

Loading

FilipLeitner commented Jan 12, 2024 •

edited

Loading

FilipLeitner commented Jan 19, 2024

jmacura left a comment

jmacura Feb 12, 2024

FilipLeitner Feb 13, 2024 •

edited

Loading

jmacura commented Feb 13, 2024

Secondary entry points to allow better dead-code elimination #4628

Secondary entry points to allow better dead-code elimination #4628

Conversation

FilipLeitner commented Jan 11, 2024 • edited Loading

Description

Related issues or pull requests

Pull request type

Do you introduce a breaking change?

Checklist

FilipLeitner commented Jan 11, 2024 • edited Loading

TBD:

FilipLeitner commented Jan 12, 2024 • edited Loading

FilipLeitner commented Jan 19, 2024

jmacura left a comment

Choose a reason for hiding this comment

jmacura Feb 12, 2024

Choose a reason for hiding this comment

FilipLeitner Feb 13, 2024 • edited Loading

Choose a reason for hiding this comment

jmacura commented Feb 13, 2024

FilipLeitner commented Jan 11, 2024 •

edited

Loading

FilipLeitner commented Jan 11, 2024 •

edited

Loading

FilipLeitner commented Jan 12, 2024 •

edited

Loading

FilipLeitner Feb 13, 2024 •

edited

Loading