Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Layer-manager and add-vector services (branch secondary-entry) #4667

Merged
merged 7 commits into from
Feb 19, 2024
Merged

Split Layer-manager and add-vector services (branch secondary-entry) #4667

merged 7 commits into from
Feb 19, 2024

Conversation

FilipLeitner
Copy link
Collaborator

@FilipLeitner FilipLeitner commented Jan 29, 2024 •
edited
Loading

Description

  • split layermanger ervice into more files. Id say first iteration its still a huge - 965lines
  • move layermanger related map event handlers to the service so that the component is optional from this point of view eg. independent service functionality

Related issues or pull requests

#4666

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)
  • I am unsure (we'll look into it together)

Do you introduce a breaking change?

  • Yes
  • No
  • I am unsure (no worries, we'll find out)

Checklist

  • I understand and agree that the changes in this PR will be licensed under the [MIT License]
  • I have followed the guidelines for contributing
  • The proposed change fits to the content of the code of conduct
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally)
  • I'm lost; why do I have to check so many boxes? Please help!

@FilipLeitner FilipLeitner requested a review from jmacura as a code owner January 29, 2024 16:36
@FilipLeitner FilipLeitner changed the title Split lm Split Layer-manager service Feb 1, 2024
@FilipLeitner FilipLeitner changed the title Split Layer-manager service Split Layer-manager and add-vector services Feb 1, 2024
@FilipLeitner
refactor: Split layermanager service into more files
4c23f53 
Move layermanager related subscriptions from component to service
@FilipLeitner
refactor: Unbind map event handlers of layermanager service
360ff83
@FilipLeitner
fix: suspendEvents for init layers
f953b7a 
Set up event handlers after initial layers are parsed
@FilipLeitner
refactor: Split add vector service
0fe3980 
Dynamically load some of OL format classes
@FilipLeitner
test(compositions): Fix failing compositions test
cb1e4ca
@FilipLeitner
feat: Add map eventhandlerset event
0246a3c 
Would be used isntead of mapService.loaded to register layers
@FilipLeitner FilipLeitner linked an issue Feb 15, 2024 that may be closed by this pull request
Split Layer-manager and add-vector services, move layermanger related map event handlers to the service #4703
Closed
@jmacura jmacura merged commit 9d93575 into secondary-entry Feb 19, 2024
1 check passed
@jmacura jmacura deleted the split-lm branch February 19, 2024 12:30
@jmacura jmacura restored the split-lm branch February 19, 2024 12:38
@jmacura jmacura changed the title Split Layer-manager and add-vector services Split Layer-manager and add-vector services (branch secondary-entry) Feb 19, 2024
@jmacura
Copy link
Collaborator

jmacura commented Feb 19, 2024

Note: this PR has been incorrectly merged into secondary-entry branch. It was recreated as a PR to develop branch: #4708

@jmacura jmacura mentioned this pull request Feb 19, 2024
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacura jmacura jmacura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split Layer-manager and add-vector services, move layermanger related map event handlers to the service
2 participants
@FilipLeitner @jmacura