Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New toasts and icons #5551

Merged
merged 25 commits into from
Feb 14, 2025
Merged

New toasts and icons #5551

merged 25 commits into from
Feb 14, 2025

Conversation

FilipLeitner
Copy link
Collaborator

@FilipLeitner FilipLeitner commented Feb 11, 2025

Description

Toasts

  • added configuration param toastAnchor which can be used to control whether the toast messages will be anchored to the map or to the screen
  • toast message can be positioned to top or bottom, left/center/right which we dont actually utilise yet. Only bottom-right or left is chosen based on the sidebar position

toast-ui

Icons

  • new icons can be added by chosing from https://fontawesome.com/search?ic=free. Adding icon name (without fa prefix) to the txt file found in projects/hslayers/css/fontawesome and running npm run subset-icons
  • most of the icons should be avaialable in both solid or regular versions (we use mostly solids for now)
  • icon subseting script is exposed in build and can be used via command line to generate custom subset necessary for container app as python "${SCRIPT_PATH}" --icons-file "${ICONS_FILE}" --output-file "${OUTPUT_FILE}". Generated custom-fa-icons.css file needs to be then included into app styles eg. @use "./custom-fa-icons.css

Related issues or pull requests

Please list issues or pull requests that the changes you propose are related to. It does not matter if they are still open and/or unmerged, any link is appreciated.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)
  • I am unsure (we'll look into it together)

Do you introduce a breaking change?

  • Yes
  • No
  • I am unsure (no worries, we'll find out)

Checklist

  • I understand and agree that the changes in this PR will be licensed under the [MIT License]
  • I have followed the guidelines for contributing
  • The proposed change fits to the content of the code of conduct
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally)
  • I'm lost; why do I have to check so many boxes? Please help!

@FilipLeitner FilipLeitner linked an issue Feb 11, 2025 that may be closed by this pull request
@FilipLeitner FilipLeitner force-pushed the toasts-and-icons branch 2 times, most recently from 8c7e1c9 to eadd8e4 Compare February 12, 2025 12:55
Copy link
Collaborator

@jmacura jmacura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toasts and icons are nice, thanks!
Some impressions:

What about the font in the sidebar menu?
image


These chevrons are not animated any more.
image
In that matter, I would use chevron-down and chevron-up, and move them to the left side, before the texts.


A simple "x"-like cross would be better here I think.
image


How did these icons get in this place?
image


Perhaps "mountain-city" or "globe" would be more appropriate than "mountain-sun" for hs-cesium switch... Idk
image

@FilipLeitner
Copy link
Collaborator Author

All fixed.

  • icons where just for the test purposes in index.html of test-app
  • changed cesium toggle to globe
  • ban icon mostly replaced with xmark or ereaser
  • sidebar font had high font weight
  • chevrons replaced with just one - animated. Now we have rotate class utiltiy

Copy link
Collaborator

@jmacura jmacura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb! The animation of chevrons is cool 😎

@jmacura jmacura merged commit bd13937 into develop Feb 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI of toast messages
2 participants