-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New toasts and icons #5551
New toasts and icons #5551
Conversation
8c7e1c9
to
eadd8e4
Compare
…ne possible positions
…te scrit updating font subset
…and to create custom icon additons
613716d
to
cbb69b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The toasts and icons are nice, thanks!
Some impressions:
What about the font in the sidebar menu?
These chevrons are not animated any more.
In that matter, I would use chevron-down and chevron-up, and move them to the left side, before the texts.
A simple "x"-like cross would be better here I think.
How did these icons get in this place?
Perhaps "mountain-city" or "globe" would be more appropriate than "mountain-sun" for hs-cesium switch... Idk
All fixed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superb! The animation of chevrons is cool 😎
Description
Toasts
toastAnchor
which can be used to control whether the toast messages will be anchored to the map or to the screenIcons
projects/hslayers/css/fontawesome
and runningnpm run subset-icons
solid
orregular
versions (we use mostly solids for now)python "${SCRIPT_PATH}" --icons-file "${ICONS_FILE}" --output-file "${OUTPUT_FILE}"
. Generatedcustom-fa-icons.css
file needs to be then included into app styles eg.@use "./custom-fa-icons.css
Related issues or pull requests
Please list issues or pull requests that the changes you propose are related to. It does not matter if they are still open and/or unmerged, any link is appreciated.
Pull request type
Please check the type of change your PR introduces:
Do you introduce a breaking change?
Checklist
npm test
locally)