Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Update tests - make all tests pass #1324

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Conversation

jarzec
Copy link
Contributor

@jarzec jarzec commented Oct 21, 2024

  • 22a337c updates outdated results for all tests except mixed-bugfix-for-ufcs-non-local.cpp2.
  • c6617a6 includes all compilation failures/crashes caused by the current version of mixed-bugfix-for-ufcs-non-local.cpp2 with UFCS recently restored in 2992560.
    • No compiler is able to compile the current state of mixed-bugfix-for-ufcs-non-local.cpp2.
    • Clang 18 crashes with unrepeatable error message for both C++20 and C++23.
    • Further investigation required to identify the cause.
    • The commit was added to simplify analysis of the problem as reported by all modern compilers.
    • Even if the all issues are due to compiler bugs having all compilers fail to compile the test makes the test somewhat pointless.
  • a06f0e7 reverts UFCS test restore of 2992560 for further investigation.
  • 3c8f5c4 updates test results of mixed-bugfix-for-ufcs-non-local.cpp2.
    • Makes all regression tests pass.

@@ -38,7 +38,7 @@ d: _ == t<o.f()>(); // Fails on Clang 12 (lambda in unevaluated context).

u: @struct type = {
b: bool == o.f();
c: bool == :(forward x: decltype(o.f())) = x;(true); // Fails on Clang 12 (lambda in unevaluated context).
Copy link
Contributor Author

@jarzec jarzec Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Explanation] As mentioned in the PR description, the UFCS restored here in 2992560 makes all compilers report errors/crash on this tests.
For this reason I suggest to keep the regular call until the cause is identified and fixed.
4e2242f was purposely added to the PR as it might help with the investigation.

@jarzec
Copy link
Contributor Author

jarzec commented Oct 27, 2024

@hsutter I saw you were working on UFCS. Would you be interested in having this PR updated based on your recent mods?
EDIT: It's already done. The original version was not mergeable anyway.

@hsutter
Copy link
Owner

hsutter commented Oct 31, 2024

Thanks!

@hsutter hsutter merged commit 1032a5b into hsutter:main Oct 31, 2024
29 checks passed
@jarzec jarzec deleted the ci-update-tests branch October 31, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants