Skip to content

lxml ascii change #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2016
Merged

lxml ascii change #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
816eaf4
lxml should only ever return an ASCII string as a str
gsnedders May 7, 2016
06e1a37
Emphasise major changes in changelog, add lxml fix and noscript.
gsnedders May 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Change Log

Released on XXX

* Added ordereddict as a mandatory dependency on Python 2.6.
* **Added ordereddict as a mandatory dependency on Python 2.6.**

* Added ``lxml``, ``genshi``, ``datrie``, ``charade``, and ``all``
extras that will do the right thing based on the specific
Expand All @@ -16,17 +16,22 @@ Released on XXX

* Cease supporting DATrie under PyPy.

* Remove ``PullDOM`` support, as this hasn't ever been properly
* **Remove ``PullDOM`` support, as this hasn't ever been properly
tested, doesn't entirely work, and as far as I can tell is
completely unused by anyone.
completely unused by anyone.**

* Move testsuite to ``py.test``.

* Fix #124: move to webencodings for decoding the input byte stream;
* **Fix #124: move to webencodings for decoding the input byte stream;
this makes html5lib compliant with the Encoding Standard, and
introduces a required dependency on webencodings.
introduces a required dependency on webencodings.**

* Cease supporting Python 3.2 (in both CPython and PyPy forms).
* **Cease supporting Python 3.2 (in both CPython and PyPy forms).**

* **Fix comments containing double-dash with lxml 3.5 and above.**

* **Use scripting disabled by default (as we don't implement
scripting).**


0.9999999/1.0b8
Expand Down
2 changes: 1 addition & 1 deletion html5lib/treewalkers/lxmletree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def ensure_str(s):
elif isinstance(s, text_type):
return s
else:
return s.decode("utf-8", "strict")
return s.decode("ascii", "strict")


class Root(object):
Expand Down