The next generation

After a year of sitting around for almost exactly a year (I'm not counting april), I picked up BagelBot and put it in a strong dev environment where I can easily work. In addition my understanding of Lua has expanded, leading to dramatic improvement of code.
BagelBot is now Allium, this is its new look.
- Added functionality to automatically locate the chatbox
- Renamed all 'bagelbot' functions to 'allium' ones
- Refactored plugin loading. Plugins are now loaded using the .register method, giving access to persistence, command, and thread generating
- Due to the simplicity of the plugin structure now (plugins are single files, instead of directories), the plugin loading process has been significantly reduced
- I have discovered that pcall can pass arguments into a function, that is used now instead of the old '.out' method.
- In addition to commands getting the name of the user and the arguments, a third parameter has now been provided to give data such as a handy function to throw when the user provides invalid arguments.
- Relocated all BagelBot commands to a core plugin: allium-stem
- Refactored all BagelBot commands to the Allium standard
- startup.lua has been for the most part commented out. Will be working on it in the next couple of commits.

.gitignore

@@ -1,2 +1,2 @@
-plugins/
+.repolist
 persistence.json

allium.lua

@@ -0,0 +1,298 @@
+print("Loading Allium")
+print("Initializing API")
+
+local mName = "<&r&dAll&5&h(Hugeblank was here. Hi.)&i(https://www.youtube.com/watch?v=PomZJao7Raw)i&r&dum&r>" --bot title
+local color = require("color") --Sponsored by roger109z
+local allium = {} -- API table
+local plugins = {} -- Plugin table
+
+allium.assert = function(condition, message, level)
+	if not condition then error(message, level) end
+end
+
+local assert = allium.assert
+
+allium.sanitize = function(name)
+	if name then
+		return name:lower():gsub(" ", "-")
+	end
+end
+
+allium.tell = function(name, message, hidetag, botname) --allium.tell as documented in README
+    local m
+    if type(message) == "string" then
+        m = message
+    else
+        m = ""
+    end
+    if type(botname) ~= "string" then
+    	botname = mName
+    end
+    local _, test = commands.tellraw(name, color.format((function(hidetag)if hidetag then return "" else return botname.."&r " end end)(hidetag)..m))
+    if type(message) == "table" then
+        for k, v in pairs(message) do
+            local _, l = commands.tellraw(name, color.format(v))
+        end
+    end
+    return textutils.serialise(test)
+end
+
+allium.getPlayers = function()
+	local didexec, input = commands.exec("list")
+	if not didexec then 
+		local _, users = commands.testfor("@a")
+		local out = {}
+		for i = 1, #users do
+			out[#out+1] = string.sub(users[i], 7, -1)
+		end
+		return out
+	end
+	local out = {}
+	for user in string.gmatch(input[2], "%S+") do
+		local comma = string.find(user, ",")
+		if not comma then comma = -1 else comma=comma-1 end
+		out[#out+1] = string.sub(user, 0, comma)
+	end
+	return out
+end
+
+allium.getInfo = function(plugin) -- Get the information of all plugins, or a single plugin
+	assert(plugin == nil or type(plugin) == "string", "Invalid argument #1 (string expected, got"..type(plugin)..")", 3)
+	if plugin then
+		plugin = allium.sanitize(plugin)
+	end
+	assert(command == nil or type(command) == "string", "Invalid argument #2 (string expected, got"..type(command)..")", 3)
+	if command then
+		assert(plugin, "Invalid argument #1 (string expected, got"..type(plugin)..")", 3)
+	end
+	if plugin then
+		assert(plugins[plugin], "Invalid argument #1 (plugin "..plugin.." does not exist)", 3)
+		if command then
+			assert(plugins[plugin].commands[command], "Invalid argument #2 (command "..command.." does not exist in plugin "..plugin..")", 3)
+		end
+	end
+	if plugin then
+		local res = {[plugin] = {}}
+		for name, command_data in pairs(plugins[plugin].commands) do
+			res[plugin][name] = {info = command_data.info, usage = command_data.usage}
+		end
+		return res
+	else
+		local res = {}
+		for p_name, plugin in pairs(plugins) do
+			res[p_name] = {}
+			for c_name, command_data in pairs(plugin.commands) do
+				res[p_name][c_name] = {info = command_data.info, usage = command_data.usage}
+			end
+		end
+		return res
+	end
+end
+
+allium.getName = function(plugin)
+	assert(type(plugin) == "string", "Invalid argument #1 (string expected, got "..type(plugin)..")", 3)
+	if plugins[plugin] then
+		return plugins[plugin].name
+	end
+end
+
+allium.register = function(p_name, fullname)
+	assert(type(p_name) == "string", "Invalid argument #1 (string expected, got "..type(p_name)..")", 3)
+	local real_name = allium.sanitize(p_name)
+	assert(plugins[real_name] == nil, "Invalid argument #1 (plugin exists under name "..real_name..")", 3)
+	plugins[real_name] = {threads = {}, commands = {}, name = fullname or p_name}
+	local funcs = {}
+	local this = plugins[real_name]
+
+	funcs.command = function(c_name, command, info, usage) -- name: name | command: executing function | info: help information | usage: string for improper inputs
+		assert(type(c_name) == "string", "Invalid argument #1 (string expected, got "..type(c_name)..")", 3)
+		local real_name = allium.sanitize(c_name)
+		assert(type(command) == "function", "Invalid argument #2 (function expected, got "..type(command)..")", 3)
+		assert(this.commands[real_name] == nil, "Invalid argument #2 (command exists under name "..real_name.." for plugin "..this.name..")", 3)
+		assert(type(info) == "string", "Invalid argument #3 (string expected, got "..type(info)..")", 3)
+		this.commands[real_name] = {command = command, info = info, usage = usage}
+	end
+
+	funcs.thread = function(thread)
+		assert(type(thread) == "function", "Invalid argument #1 (function expected, got "..type(thread)..")", 3)
+		this.threads[#this.threads+1] = thread
+	end
+
+	funcs.getPersistence = function(name)
+		if fs.exists("persistence.json") then
+			local fper = fs.open("persistence.json", "r")
+			local tpersist = textutils.unserialize(fper.readAll())
+			fper.close()
+			if not tpersist[p_name] then
+				tpersist[p_name] = {}
+			end
+			if type(name) == "string" then
+				return tpersist[p_name][name]
+			end
+		end
+		return false
+	end
+
+	funcs.setPersistence = function(name, data)
+		local tpersist
+		if fs.exists("persistence.json") then
+			local fper = fs.open("persistence.json", "r")
+			tpersist = textutils.unserialize(fper.readAll())
+			fper.close()
+		end
+		if not tpersist[p_name] then
+			tpersist[p_name] = {}
+		end
+		if type(name) == "string" then
+			tpersist[p_name][name] = data
+			local fpers = fs.open("persistence.json", "w")
+			fpers.write(textutils.serialise(tpersist))
+			fpers.close()
+			return true
+		end
+		return false
+	end
+
+	return funcs
+end
+
+-- Finding the chat module
+for _, side in pairs(peripheral.getNames()) do
+	if peripheral.getMethods(side) then
+		for _, method in pairs(peripheral.getMethods(side)) do
+			if method == "capture" then
+				allium.side = side
+				peripheral.call(side, method, "^!")
+				break
+			end
+		end
+	end
+	if allium.side then break end
+end
+
+if not allium.side then
+	printError("Cannot find chat module")
+	return
+end
+
+_G.allium = allium -- Globalizing Allium API
+
+
+do -- Plugin loading process
+	print("Loading plugins...")
+	local dir = shell.dir()
+	if fs.exists(dir.."plugins") then
+		for _, plugin in pairs(fs.list(dir.."plugins")) do
+			if not fs.isDir(dir.."plugins/"..plugin) then
+				local file, err = loadfile(dir.."plugins/"..plugin)
+				if not file then
+					printError(err)
+				else
+					local suc, err = pcall(file)
+					if not suc then
+						printError(err)
+					end
+				end
+			end
+		end
+	end
+end
+
+local main = function()
+	while true do
+		local _, message, _, name = os.pullEvent("chat_capture") --Pull chat messages
+		if string.find(message, "!") == 1 then --are they for allium?
+			args = {}
+			for k in string.gmatch(message, "%S+") do --put all arguments spaced out into a table
+				args[#args+1] = k
+			end
+			local cmd = args[1]:sub(2, -1) -- Strip the !
+			table.remove(args, 1) --remove the first parameter given (!command)
+			local cmd_exec
+			if not string.find(cmd, ":") then --did they not specify the plugin source?
+				for p_name, plugin in pairs(plugins) do --nope... gonna have to find it for them.
+					for c_name, command in pairs(plugin.commands) do
+						if c_name == cmd then --well I found it, but there may be more...
+							cmd_exec = {command = command, plugin = p_name} --split into command function, source
+							break
+						end
+					end
+					if cmd_exec then break end -- Exit this loop, we've found the command we're looking for
+				end
+			else --hey they did! +1 karma.
+				local splitat = string.find(cmd, ":")
+				local p_name, c_name = string.sub(cmd, 1, splitat-1), string.sub(cmd, splitat+1, -1)
+				if plugins[p_name] then --check plugin existence
+					if plugins[p_name].commands[c_name] then --check command existence
+						cmd_exec = {command = plugins[p_name].commands[c_name], plugin = p_name} --split it into the function, and then the source
+					end
+				end
+			end
+			if cmd_exec then --is there really a command?
+				local data = { -- Infrequently used data to pass onto the command being executed
+					usage = function(name) allium.tell(name, "&c"..cmd.." "..cmd_exec.command.usage) end,
+					autofill = cmd_exec.command.usage
+				}
+	    		local stat, err = pcall(cmd_exec.command.command, name, args, data) --Let's execute the command in a safe environment that won't kill allium
+	    		if stat == false then--it crashed...
+	    			allium.tell(name, "&4"..cmd.." crashed! This is likely not your fault, but the developer's. Please contact the developer of &a"..cmd_exec.plugin.."&4. Error:\n&c"..err)
+	    			printError(cmd.." errored. Error:\n"..err)
+	    		end
+    		else --this isn't even a valid command...
+	    		allium.tell(name, "&6Invalid Command, use &c&g(!allium:help)!help&r&6 for assistance.") --bleh!
+    		end
+	    end
+	end
+end
+
+local threads = {} -- Temporary
+
+threads[#threads+1] = coroutine.create(main) --Add main to the thread table
+
+if not fs.exists("persistence.json") then --In the situation that this is a first installation, let's add persistence.json
+	local fpers = fs.open("persistence.json", "w")
+	fpers.write("{}")
+	fpers.close()
+end
+
+print("Allium started.")
+allium.tell("@a", "&eHello World!")
+--This clump is pulled and adapted for what I need it for, parallel.waitForAll, for a table of coroutines. Its origin is in /rom/apis/parallel.lua in CraftOS.
+local count = #threads
+local living = count
+
+local tFilters = {}
+local eventData = { n = 0 }
+while true do
+	for n=1,count do
+		local r = threads[n]
+		if r then
+			if tFilters[r] == nil or tFilters[r] == eventData[1] or eventData[1] == "terminate" then
+    			local ok, param = coroutine.resume( r, table.unpack( eventData, 1, eventData.n ) )
+				if not ok then
+					error( param, 0 )
+				else
+					tFilters[r] = param
+				end
+				if coroutine.status( r ) == "dead" then
+					threads[n] = nil
+					living = living - 1
+					if living <= 0 then
+						return n
+					end
+				end
+			end
+		end
+	end
+	for n=1,count do
+		local r = threads[n]
+		if r and coroutine.status( r ) == "dead" then
+			threads[n] = nil
+			living = living - 1
+			if living <= 0 then
+				return n
+			end
+		end
+	end
+	eventData = table.pack( os.pullEventRaw() )
+end

color.lua

@@ -1,3 +1,5 @@
+local this = {}
+
 local cTable = {
     ["0"] = "black",
     ["1"] = "dark_blue",
@@ -68,7 +70,7 @@ local function copy(tbl)
 	end
 	return ret
 end
-format = function(sText, bAction)
+this.format = function(sText, bAction)
 	if type(bAction) ~= "boolean" then
 		bAction = true
 	end
@@ -104,7 +106,7 @@ format = function(sText, bAction)
 				current["hoverEvent"] = true
 				local ind = string.find(v[2], ")")
 				if ind ~= nil then
-					current["hoverText"] = format(string.sub(v[2], 2, ind-1), false)
+					current["hoverText"] = this.format(string.sub(v[2], 2, ind-1), false)
 					v[2] = v[2]:sub(ind+1)
 				else
 					current["hoverText"] = v[2]
@@ -133,7 +135,7 @@ format = function(sText, bAction)
     return outText
 end
 
-deformat = function(string)
+this.deformat = function(string)
     local seperated = {}
 	local out = ""
     for k in string.gmatch(sText, "[^&]+") do
@@ -145,3 +147,5 @@ deformat = function(string)
 	end
 	return out
 end
+
+return this