Fix all Svelte lint warnings and flaky CI test#2179
Merged
Conversation
beforeAll/afterAll/afterEach were at module scope, outside the describe block. In CI the DB connection isn't ready at module-level hook time, causing "Cannot read properties of undefined (reading 'users')".
gary149
force-pushed
the
fix/lint-warnings
branch
from
9881526 to
1035538
Compare
gary149
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state_referenced_locallywarnings by replacing prop-initialized$state()with default values +$effect.presync, and restructuring MarkdownRenderer to use$derivedfor sync blocksa11y_no_static_element_interactionsin AudioPlayer by addingrole="slider"with proper ARIA attributessvelte-ignore a11y_autofocuscomment in NavConversationItem09-delete-empty-conversationstest by moving lifecycle hooks insidedescribeblock and awaitingreadybefore accessing DB collectionsTest plan
npm run check— 0 errors, 1 warning (pre-existing, already suppressed in ESLint)npm run lint— 0 errorsnpm run test— 22 files, 155 tests passednpm run build— success