-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHAPTER] New chapter on supervised fine tuning based on smol course #777
[CHAPTER] New chapter on supervised fine tuning based on smol course #777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice start! 🔥
@Vaibhavs10 I've done this:
Next, I'd like to add the colab links to some pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me, I can do a review as soon as you add the colabs? so that I look at all in one-go? does that work?
Makes total sense. When it's ready I'll change status and ping you. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very solid content, I definitely learnt a thing whilst reviewing, most of these are minor nits! 🔥
Co-authored-by: vb <[email protected]>
Co-authored-by: vb <[email protected]>
Co-authored-by: vb <[email protected]>
…shaw/course into add-supervised-finetuning
@Vaibhavs10 Thanks for the review! I responded to all the comments and worked a bit more on the SFT page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested @lewtun to give it a look as well, otherwise this is good to ship imo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice chapter with a great flow and clear, easy to understand text - well done @burtenshaw ! I left a few minor comments, but agree with @Vaibhavs10 that this can go live whenever you want
This is a draft PR for discussion.
It would be cool to reuse the smol course chapter on SFT in the HF NLP course.
Here I've just copied across the content, but here the next step I would propose:
Let me know if others thing this is useful, and I'm open to feedback.
This PR now depends on these notebooks huggingface/notebooks#553