Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHAPTER] New chapter on supervised fine tuning based on smol course #777

Merged
merged 31 commits into from
Feb 17, 2025

Conversation

burtenshaw
Copy link
Collaborator

@burtenshaw burtenshaw commented Jan 29, 2025

This is a draft PR for discussion.

It would be cool to reuse the smol course chapter on SFT in the HF NLP course.

Here I've just copied across the content, but here the next step I would propose:

  • - update the structure to course norms. i.e. mdx and no ipynb
  • - change the style
  • - link back to relevant course chapters

Let me know if others thing this is useful, and I'm open to feedback.

This PR now depends on these notebooks huggingface/notebooks#553

@burtenshaw burtenshaw marked this pull request as draft January 29, 2025 13:47
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice start! 🔥

@burtenshaw
Copy link
Collaborator Author

@Vaibhavs10 I've done this:

  • refactored the SFT content into an NLP course structure.
  • added quizzes
  • added tips to do exercises

Next, I'd like to add the colab links to some pages

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me, I can do a review as soon as you add the colabs? so that I look at all in one-go? does that work?

@burtenshaw
Copy link
Collaborator Author

Makes total sense. When it's ready I'll change status and ping you.

@burtenshaw burtenshaw marked this pull request as ready for review February 5, 2025 19:20
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@burtenshaw burtenshaw changed the title [DRAFT] [CHAPTER] New chapter on supervised fine tuning based on smol course [CHAPTER] New chapter on supervised fine tuning based on smol course Feb 5, 2025
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very solid content, I definitely learnt a thing whilst reviewing, most of these are minor nits! 🔥

chapters/en/chapter11/1.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/1.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/1.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/2.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/2.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/5.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/5.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/5.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/5.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/5.mdx Show resolved Hide resolved
@burtenshaw
Copy link
Collaborator Author

@Vaibhavs10 Thanks for the review! I responded to all the comments and worked a bit more on the SFT page.

@Vaibhavs10 Vaibhavs10 requested a review from lewtun February 13, 2025 12:55
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested @lewtun to give it a look as well, otherwise this is good to ship imo!

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice chapter with a great flow and clear, easy to understand text - well done @burtenshaw ! I left a few minor comments, but agree with @Vaibhavs10 that this can go live whenever you want

chapters/en/_toctree.yml Show resolved Hide resolved
chapters/en/chapter11/1.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/1.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/2.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/2.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/3.mdx Show resolved Hide resolved
chapters/en/chapter11/3.mdx Show resolved Hide resolved
chapters/en/chapter11/4.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/4.mdx Outdated Show resolved Hide resolved
chapters/en/chapter11/5.mdx Show resolved Hide resolved
@burtenshaw burtenshaw merged commit f1a8e79 into huggingface:main Feb 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants