Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add onnxruntime-migraphx as part of check for onnxruntime in import_utils.py #10624

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

kahmed10
Copy link
Contributor

What does this PR do?

The onnxruntime check would fail if only onnxruntime-migraphx was installed. Added to the list of candidates.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Core library:

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@echarlaix could you give this a look too?

@sayakpaul sayakpaul merged commit 04d4092 into huggingface:main Jan 23, 2025
11 of 12 checks passed
@sayakpaul
Copy link
Member

Thank you @kahmed10!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants