Conversation
The sequential offload conflict check and model offload warning in
`Pipeline.to()` only applied to CUDA and Intel XPU devices. Ascend NPU
is also an accelerator where moving a pipeline to the device conflicts
with offloading — users calling `.to("npu")` should get the same
clear error/warning instead of silently broken behavior.
5 changes, 2 insertions(+), 2 deletions(-) — adds "npu" to the
device_type lists at lines 2691 and 2704 (previously ["cuda", "xpu"]).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sequential offload conflict check (line 2691) and model offload warning (line 2704) in
Pipeline.to()only applied to CUDA and Intel XPU devices. Ascend NPU is also an accelerator where moving a pipeline to the device conflicts with offloading — users calling.to("npu")should get the same clear error/warning instead of silently broken behavior.Changes:
["cuda", "xpu"]→["cuda", "xpu", "npu"]at two guard points (lines 2691 and 2704)Effect:
"cuda""xpu""npu""cpu""hpu"2 insertions(+), 2 deletions(-) — clean, minimal, device-agnostic.
Verified on Ascend 910B NPU:
device_type='npu'now correctly captured by the guard list.