fix: Compute real standard deviation in output instead of mean().#21
Merged
fix: Compute real standard deviation in output instead of mean().#21
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the computation of standard deviation in the output, which previously incorrectly displayed the mean value instead. The fix implements Welford's online algorithm to compute the running variance and standard deviation of FLOPS measurements.
Changes:
- Added support for computing real standard deviation using Welford's algorithm
- Refactored FLOPS update logic into a dedicated
update_flops()method - Added new fields
flops_meanandflops_m2to track running statistics
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the computation of standard deviation in output (used to wrongly be the
meanvalue).Fixes #13