feat(hub): adding downloadFileToCacheDirWithProgress
function
#1334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #1331
To be able to offer a
snapshotDownloadWithProgress
method, similar touploadFilesWithProgress
the function called bysnapshotDownload
should also have aWithProgress
version.Splitting the
downloadFileToCacheDir
functionTo avoid doing a big copy paste of the
downloadFileToCacheDir
function, I needed to split it.DownloadFileToCacheDirParams
to avoid repeating the params everywherepreparePaths
to determine the paths based on the paramsensureDirectories
to mkdir the directoriesprepareDownloadFileToCacheDir
to handle all the functions abovedownloadAndStoreFile
to do the heavy logic of downloading sodownloadFileToCacheDir
is simpler.Those functions are exported, so
downloadFileToCacheDirWithProgress
can nicely use themTesting
downloadFileToCacheDirWithProgress