Public tokenizer errors, hasChatTemplate #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ml-explore/mlx-swift-examples#181 (comment), ml-explore/mlx-swift-examples#150
In addition to making the tokenizer errors public, this PR adds a new
hasChatTemplate
property. We could also create an accessor for the chat template itself if needed, but we still need to support array values that are in the process of being deprecated anyway.Would these changes suffice for mlx-swift, @davidkoski? Do you think we'd need something like Python's
tokenize=False
argument, like @awni mentioned?