Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CLI flag disable-spans to toggle span trace logging #481

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

obloomfield
Copy link
Contributor

@obloomfield obloomfield commented Feb 1, 2025

What does this PR do?

Adds a CLI flag, disable-spans (or environment variable DISABLE_SPANS) to remove the spans list and current span from the log trace when enabled. In production environments, the span's trace could contain sensitive user information, so this feature would be crucial for security compliance.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Follow-up Features

@obloomfield obloomfield changed the title add CLI flag disable-spans to disable span trace logging add CLI flag disable-spans to toggle span trace logging Feb 1, 2025
Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Narsil Narsil merged commit f1634ba into huggingface:main Mar 26, 2025
@Narsil
Copy link
Collaborator

Narsil commented Mar 26, 2025

Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants