Skip to content

Fix insta snapshots for ModernBERT tests #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alvarobartt
Copy link
Member

What does this PR do?

This PR fixes the insta snapshots for ModernBERT as upon the merge of #616 the tests were failing on main as per https://github.com/huggingface/text-embeddings-inference/actions/runs/15394613692/job/43312063692.

To update the insta snapshots in this PR, we ran cargo test --release -F candle --test test_modernbert and then cargo insta review to review and accept the updated / fixed snapshots.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Narsil

@alvarobartt alvarobartt requested a review from Narsil June 3, 2025 09:48
@alvarobartt
Copy link
Member Author

Closed in favor of #620

@alvarobartt alvarobartt closed this Jun 3, 2025
@alvarobartt alvarobartt deleted the fix-modernbert-broken-tests branch June 3, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant