Making pdf-render-service optional

humio · Feb 13, 2025 · 75f0af0 · 75f0af0
1 parent ba802c5
commit 75f0af0
Show file tree

Hide file tree

Showing 9 changed files with 57 additions and 2 deletions.
diff --git a/api/v1alpha1/humiopdfrenderservice_types.go b/api/v1alpha1/humiopdfrenderservice_types.go
@@ -39,6 +39,9 @@ type HumioPdfRenderServiceSpec struct {
 
 	// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
 	// Important: Run "make" to regenerate code after modifying this file
+	// Enable indicates whether the PDF rendering service should be created.
+	// +optional
+	Enabled *bool `json:"enabled,omitempty"`
 
 	// Image is the Docker image to use for the PDF rendering service.
 	Image string `json:"image"`

diff --git a/api/v1alpha1/zz_generated.deepcopy.go b/api/v1alpha1/zz_generated.deepcopy.go
diff --git a/charts/humio-operator/crds/core.humio.com_humiopdfrenderservices.yaml b/charts/humio-operator/crds/core.humio.com_humiopdfrenderservices.yaml
@@ -951,6 +951,12 @@ spec:
                 description: Annotations allows to specify custom annotations for
                   the pods.
                 type: object
+              enabled:
+                description: |-
+                  INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
+                  Important: Run "make" to regenerate code after modifying this file
+                  Enable indicates whether the PDF rendering service should be created.
+                type: boolean
               env:
                 description: Env allows to specify environment variables for the service.
                 items:

diff --git a/charts/humio-operator/templates/pdfrenderservice.yaml b/charts/humio-operator/templates/pdfrenderservice.yaml
@@ -0,0 +1,16 @@
+{{ if .Values.pdfRenderService.enabled }}
+apiVersion: core.humio.com/v1alpha1
+kind: HumioPdfRenderService
+metadata:
+  labels:
+    app.kubernetes.io/name: humiopdfrenderservice
+    app.kubernetes.io/instance: {{.Release.Name}}-humiopdfrenderservice
+    app.kubernetes.io/part-of: humio-operator
+    app.kubernetes.io/managed-by: helm
+    app.kubernetes.io/created-by: humio-operator
+  name: {{.Release.Name}}-humiopdfrenderservice
+spec:
+  enabled: {{.Values.pdfRenderService.enabled}}
+  image: humio/humio-pdf-render-service:latest
+  replicas: 1
+{{ end }}
diff --git a/charts/humio-operator/values.yaml b/charts/humio-operator/values.yaml
@@ -43,3 +43,6 @@ operator:
 certmanager: true
 defaultHumioCoreImage: ""
 defaultHumioHelperImage: ""
+
+ppdfRenderService:
+  enabled: true
diff --git a/config/crd/bases/core.humio.com_humiopdfrenderservices.yaml b/config/crd/bases/core.humio.com_humiopdfrenderservices.yaml
@@ -951,6 +951,12 @@ spec:
                 description: Annotations allows to specify custom annotations for
                   the pods.
                 type: object
+              enabled:
+                description: |-
+                  INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
+                  Important: Run "make" to regenerate code after modifying this file
+                  Enable indicates whether the PDF rendering service should be created.
+                type: boolean
               env:
                 description: Env allows to specify environment variables for the service.
                 items:

diff --git a/controllers/humiopdfrenderservice_controller.go b/controllers/humiopdfrenderservice_controller.go
@@ -49,6 +49,12 @@ func (r *HumioPdfRenderServiceReconciler) Reconcile(ctx context.Context, req ctr
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
 
+	// If the CR is disabled, skip reconciliation.
+	if humioPdfRenderService.Spec.Enabled != nil && !*humioPdfRenderService.Spec.Enabled {
+		logger.Info("HumioPdfRenderService is disabled, skipping reconciliation", "Name", humioPdfRenderService.Name)
+		return ctrl.Result{}, nil
+	}
+
 	// If the CR's namespace is empty, default it.
 	if humioPdfRenderService.Namespace == "" {
 		ns := r.Namespace

diff --git a/docs/api.md b/docs/api.md
@@ -35708,6 +35708,15 @@ HumioPdfRenderServiceSpec defines the desired state of HumioPdfRenderService
           Annotations allows to specify custom annotations for the pods.<br/>
         </td>
         <td>false</td>
+      </tr><tr>
+        <td><b>enabled</b></td>
+        <td>boolean</td>
+        <td>
+          INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
+Important: Run "make" to regenerate code after modifying this file
+Enable indicates whether the PDF rendering service should be created.<br/>
+        </td>
+        <td>false</td>
       </tr><tr>
         <td><b><a href="#humiopdfrenderservicespecenvindex">env</a></b></td>
         <td>[]object</td>

diff --git a/examples/humiopdf-render-service.yaml b/examples/humiopdf-render-service.yaml
@@ -11,6 +11,7 @@ metadata:
   annotations:
     iam.amazonaws.com/role: ''
 spec:
+  enabled: true
   affinity:
     nodeAffinity:
       requiredDuringSchedulingIgnoredDuringExecution:
@@ -21,11 +22,11 @@ spec:
                 values:
                   - ''
   image:
-    repository: registry.dodo.eyrie.cloud:5000/cloud/cs-pdf-render-service
+    repository: my-registry.example.com/pdf-render-service
   ingress:
     enabled: true
     hosts:
-      - host: pdf-render-service-pool-main.red.dodo.eyrie.cloud
+      - host: pdf-render-service.example.com
         port: 5123
     shared:
       enabled: false