$mol_build added MAM_NO_PULL, back init existing not-git directory #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nin-jin
reviewed
Feb 8, 2025
nin-jin
reviewed
Feb 8, 2025
nin-jin
reviewed
Feb 8, 2025
build/ensure/git/git.ts
Outdated
| protected override init_existing(dir: string) { | ||
| // Если вручную склонить ревизию hyoo/mol перед запуском билда, | ||
| // то hyoo надо проинициалзировать в соответствии с meta.ree | ||
| const repo = this.repo(dir) |
There was a problem hiding this comment.
Я каждый раз спотыкаюсь. Что такое repo?
There was a problem hiding this comment.
url + branch репозитория взятый из meta.tre
nin-jin
reviewed
Feb 8, 2025
build/ensure/vcs/vcs.ts
Outdated
| @@ -68,8 +68,14 @@ namespace $ { | |||
| } | |||
| } | |||
|
|
|||
| protected no_pull() { | |||
There was a problem hiding this comment.
Лучше использоваться позитивную логику вместо негативной, чтобы потом не ломать голову о двойное отрицание.
There was a problem hiding this comment.
переназвал pull_disable
nin-jin
reviewed
Feb 8, 2025
build/ensure/vcs/vcs.ts
Outdated
| @ $mol_mem_key | ||
| ensure( path : string ) { | ||
| if (this.no_pull()) return false |
There was a problem hiding this comment.
Я правильно понимаю, что все включение этой опции отключит не только обновление, но и установку отсутствующих зависимостей?
There was a problem hiding this comment.
переделал, что б clone остался, если репы нет
nin-jin
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.