docs(skill): split CGS app-dev skill into router + references#55
Conversation
|
Warning Review limit reached
More reviews will be available in 13 minutes and 37 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthrough
ChangesCGS App-Development Skill Restructure
Instatus Maintenance Scheduling Skill
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.agents/skills/scheduling-instatus-maintenance/SKILL.md (1)
162-168: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winClarify
expandAtcalculation with a concrete example.Line 162 shows
expandAtusing the same placeholder format asstart, but lines 166–168 note the actual value should be three days earlier. An implementer might copy the example timestamp directly without calculating the offset, causing the maintenance window to not expand at the intended time.Suggest adding a concrete example calculation, such as:
{ "start": "2026-07-15T14:00:00.000Z", "expandAt": "2026-07-12T14:00:00.000Z" }This makes it clear that
expandAtshould be exactly 72 hours (3 days) before thestarttime.💡 Proposed fix for clarity
Set `expandAt` to three days before `start` when following recent scheduled window style. In the sample above, `expandAt` uses the same timestamp format as -`start` / `end`, but the actual value should be three days earlier. +`start` / `end`. For example, if `start` is `2026-07-15T14:00:00.000Z`, set +`expandAt` to `2026-07-12T14:00:00.000Z` (exactly 72 hours earlier).Optionally, update the example payload to show both timestamps with the correct offset:
"start": "YYYY-MM-DDTHH:mm:ss.000Z", "end": "YYYY-MM-DDTHH:mm:ss.000Z", ... - "expandAt": "YYYY-MM-DDTHH:mm:ss.000Z" + "expandAt": "YYYY-MM-DDTHH:mm:ss.000Z" /* 3 days before 'start' */🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.agents/skills/scheduling-instatus-maintenance/SKILL.md around lines 162 - 168, The JSON example showing the `expandAt` field uses the same placeholder format as `start` without demonstrating the actual 3-day offset calculation, which could lead implementers to copy the example directly without the proper offset. Replace the generic `expandAt` placeholder value in the example with a concrete timestamp that is exactly 72 hours before the `start` timestamp shown in the same example, making the 3-day offset calculation explicit and clear to readers.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.agents/skills/scheduling-instatus-maintenance/SKILL.md:
- Around line 162-168: The JSON example showing the `expandAt` field uses the
same placeholder format as `start` without demonstrating the actual 3-day offset
calculation, which could lead implementers to copy the example directly without
the proper offset. Replace the generic `expandAt` placeholder value in the
example with a concrete timestamp that is exactly 72 hours before the `start`
timestamp shown in the same example, making the 3-day offset calculation
explicit and clear to readers.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: dce0c0c4-bf73-4d2a-b90b-5103d832973b
📒 Files selected for processing (10)
.agents/skills/app-development-with-cgs/SKILL.md.agents/skills/app-development-with-cgs/references/api-keys.md.agents/skills/app-development-with-cgs/references/cross-group.md.agents/skills/app-development-with-cgs/references/group-lifecycle.md.agents/skills/app-development-with-cgs/references/members-and-roles.md.agents/skills/app-development-with-cgs/references/proxy-and-records.md.agents/skills/app-development-with-cgs/references/targeting.md.agents/skills/app-development-with-cgs/references/versioning.md.agents/skills/scheduling-instatus-maintenance/SKILL.md.mcp.json
Address CodeRabbit nitpick on PR #55: the expandAt-is-3-days-before-start rule was easy to miss when copying the placeholder timestamp. Add a worked example (start 2026-07-15 -> expandAt 2026-07-12, 72h earlier) and warn against copying the start value. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Addressed the |
|
Tip For best results, initiate chat on the files or code changes.
(∧ ・ ᴥ ・ ∧) If you found this review helpful, would you consider giving us a shout-out on X? Thank you for using CodeRabbit! |
d3ac0e5 to
1453711
Compare
|
@coderabbitai the |
1453711 to
6ac6776
Compare
…rsioning Restructure the app-development-with-cgs skill from a single SKILL.md into a lean router plus reference files under references/, and add one covering how to check and interpret a deployment's version. Dedup against docs/: the skill now owns only the decisions, traps, and small stable tables an agent needs in-context; the canonical request shapes and long-form prose stay in docs/ and are linked (anchors verified). This removes the paraphrase duplication that would otherwise drift against docs/. references/versioning.md answers "what version is this deployment running" (GET /health) and what the number means for an integrator: semver, the pre-1.0 caveat that a minor bump may break the API, and where the release notes live. It also notes that production (groups.certified.app) does not expose the version endpoint yet. Preserves the permission-sets (include:) documentation that landed on main in parallel, folded into references/api-keys.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
6ac6776 to
c7983e8
Compare
Summary
Restructure the
app-development-with-cgsskill from a singleSKILL.mdinto a lean router plus reference files underreferences/, and add one covering how to check and interpret a deployment's version. No service code touched.SKILL.mdbecomes the router: auth-mode decision, a dispatch table to the reference files, an error→cause map, and a demo pointer.references/*.md(proxy-and-records, targeting, group-lifecycle, members-and-roles, cross-group, api-keys, versioning).docs/: the skill now owns only decisions, traps, and small stable tables; canonical request shapes and long-form prose stay indocs/and are linked (anchors verified). Removes the paraphrase duplication that would otherwise drift.references/versioning.mdanswers "what version is this deployment running" (GET /health) and what the number means for an integrator: semver, the pre-1.0 caveat that a minor bump may break the API, and where the release notes live. Notes that production (groups.certified.app) doesn't expose the version endpoint yet.include:) documentation that landed onmainin parallel, folded intoreferences/api-keys.md.Not in this PR
The Instatus maintenance-scheduling skill that was briefly part of this branch has moved to its canonical cross-service home in certified-infra (hypercerts-org/certified-infra#2). The ePDS copy is being removed in hypercerts-org/ePDS#180.
🤖 Generated with Claude Code