Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zksync support for core solidity package #5205

Merged
merged 253 commits into from
Jan 22, 2025

Conversation

ljankovic-txfusion
Copy link
Collaborator

@ljankovic-txfusion ljankovic-txfusion commented Jan 20, 2025

Description

ZKSync PR 1

This PR introduces ZKSync support for Solidity contracts and restructures build files directory structure.

Drive-by changes

  • Added ZKSync compilation support using zksolc via @matterlabs/hardhat-zksync-solc
  • Restructured typechain directory location to core-utils/typechain
  • Decoupled Hardhat configuration for ZKSync from EVM.
  • Updated build process to handle both standard and ZKSync contract artifacts

Related issues

None

Backward compatibility

Yes

Testing

Testing was previously in feat: zksync support PR

ljankovic-txfusion and others added 30 commits September 16, 2024 15:11
…hyperlane-monorepo-zksync into txfusion/sending-messages
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (6c631d8) to head (3adda1d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5205   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

Copy link
Member

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

.changeset/chatty-starfishes-double.md Outdated Show resolved Hide resolved
solidity/package.json Outdated Show resolved Hide resolved
@yorhodes yorhodes assigned yorhodes and unassigned yorhodes Jan 21, 2025
solidity/generate-artifact-exports.mjs Show resolved Hide resolved
solidity/package.json Outdated Show resolved Hide resolved
@paulbalaji paulbalaji enabled auto-merge January 22, 2025 18:06
@paulbalaji paulbalaji disabled auto-merge January 22, 2025 18:20
@paulbalaji paulbalaji added this pull request to the merge queue Jan 22, 2025
Merged via the queue into hyperlane-xyz:main with commit db8c090 Jan 22, 2025
39 of 45 checks passed
paulbalaji added a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants